[PATCH] [TEST] XFAIL VSSD/04_vssd_to_rasd.py because that libvirt allows the user to specify a mouse with "xen" bus type for LXC
9:21 p.m.
# HG changeset patch
# User Guolian Yun <yunguol(a)cn.ibm.com>
# Date 1227756090 28800
# Node ID 5c0fd365bb73286f3fd447939bb75ed5fb68aba9
# Parent 8807a94aa58a411d8596e717674c91c937881247
[TEST] XFAIL VSSD/04_vssd_to_rasd.py because that libvirt allows the user to specify a
mouse with "xen" bus type for LXC
Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
diff -r 8807a94aa58a -r 5c0fd365bb73 suites/libvirt-cim/cimtest/VSSD/04_vssd_to_rasd.py
--- a/suites/libvirt-cim/cimtest/VSSD/04_vssd_to_rasd.py Mon Nov 24 22:08:51 2008 -0800
+++ b/suites/libvirt-cim/cimtest/VSSD/04_vssd_to_rasd.py Wed Nov 26 19:21:30 2008 -0800
@@ -46,7 +46,7 @@
from XenKvmLib import enumclass
from CimTest.Globals import logger, CIM_ERROR_ASSOCIATORS, CIM_ERROR_ENUMERATE
from XenKvmLib.const import do_main
-from CimTest.ReturnCodes import PASS, FAIL
+from CimTest.ReturnCodes import PASS, FAIL, XFAIL_RC
from XenKvmLib.test_doms import destroy_and_undefine_all
from XenKvmLib import assoc
from XenKvmLib.vxml import get_class
@@ -57,6 +57,7 @@
rasd_init_list, verify_inputrasd_values
from XenKvmLib.const import default_network_name
+libvirt_bug = "00009"
sup_types = ['Xen', 'KVM', 'XenFV', 'LXC']
test_dom = "VSSDC_dom"
@@ -193,6 +194,8 @@
status = verify_displayrasd_values(rasd_instance, displayrasd)
elif 'InputResourceAllocationSettingData' in CCName:
status = verify_inputrasd_values(rasd_instance, inputrasd)
+ if status != PASS and virt== 'LXC':
+ return XFAIL_RC(libvirt_bug)
else:
status = FAIL
if status != PASS:
12:45 p.m.
+libvirt_bug = "00009"
sup_types = ['Xen', 'KVM', 'XenFV', 'LXC']
test_dom = "VSSDC_dom"
@@ -193,6 +194,8 @@
status = verify_displayrasd_values(rasd_instance, displayrasd)
elif 'InputResourceAllocationSettingData' in CCName:
status = verify_inputrasd_values(rasd_instance, inputrasd)
+ if status != PASS and virt== 'LXC':
+ return XFAIL_RC(libvirt_bug)
Instead of putting the XFAIL here, the check should go in
verify_inputrasd_values() - this way, none of the tests need to be updated.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com
8:29 p.m.
New subject: [PATCH] [TEST] XFAIL VSSD/04_vssd_to_rasd.py because that libvirt allows the user to specify a mouse with "xen" bus type for LXC
libvirt-cim-bounces(a)redhat.com wrote on 2008-12-02 02:45:46:
>
> +libvirt_bug = "00009"
> sup_types = ['Xen', 'KVM', 'XenFV', 'LXC']
>
> test_dom = "VSSDC_dom"
> @@ -193,6 +194,8 @@
> status = verify_displayrasd_values(rasd_instance,
displayrasd)
> elif 'InputResourceAllocationSettingData' in CCName:
> status = verify_inputrasd_values(rasd_instance,
inputrasd)
> + if status != PASS and virt== 'LXC':
> + return XFAIL_RC(libvirt_bug)
Instead of putting the XFAIL here, the check should go in
verify_inputrasd_values() - this way, none of the tests need to be
updated.
If XFAIL is put in verify_inputrasd_values(), we have to add another
parameter of 'virt'
to verify_inputrasd_values(), which more tests need to be updates.
Thoughts?
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
11:40 a.m.
New subject: [PATCH] [TEST] XFAIL VSSD/04_vssd_to_rasd.py because that libvirt allows the user to specify a mouse with "xen" bus type for LXC
Guo Lian Yun wrote:
libvirt-cim-bounces(a)redhat.com wrote on 2008-12-02 02:45:46:
> >
> > +libvirt_bug = "00009"
> > sup_types = ['Xen', 'KVM', 'XenFV', 'LXC']
> >
> > test_dom = "VSSDC_dom"
> > @@ -193,6 +194,8 @@
> > status = verify_displayrasd_values(rasd_instance,
> displayrasd)
> > elif 'InputResourceAllocationSettingData' in CCName:
> > status = verify_inputrasd_values(rasd_instance,
inputrasd)
> > + if status != PASS and virt== 'LXC':
> > + return XFAIL_RC(libvirt_bug)
>
> Instead of putting the XFAIL here, the check should go in
> verify_inputrasd_values() - this way, none of the tests need to be
updated.
If XFAIL is put in verify_inputrasd_values(), we have to add another
parameter of 'virt'
to verify_inputrasd_values(), which more tests need to be updates.
Thoughts?
Yes, that's a good point. Okay, we'll have the tests be updated for now.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com
5863
days inactive
5868
days old
3 comments
3 participants
participants (3)
-
Guo Lian Yun -
Kaitlin Rupert -
yunguol＠cn.ibm.com