Re: [Libvirt-cim] [PATCH V3 02/11] do not deregister virt classes in yum upgrade
Since I don't have the email to reply-to for a review, here is a link: https://www.redhat.com/archives/libvirt-cim/2012-December/msg00021.html I'm not sure what "$1" is in this context, let's consider setting "$1" to some variable that is more understandable in the context. Furthermore, is "0" a special number/string? How would anyone know reading the code without having knowledge of the code. John
On 03/11/2013 02:40 PM, John Ferlan wrote:
I'm not sure what "$1" is in this context, let's consider setting "$1" to some variable that is more understandable in the context. Furthermore, is "0" a special number/string? How would anyone know reading the code without having knowledge of the code.
Hi John, actually this is standard way a %post or %pre scripts are handled by RPM: the single parameter tells the scripts whether they are called during a clean install/uninstall or an update. See http://www.rpm.org/max-rpm/s1-rpm-inside-scripts.html for reference. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
participants (2)
-
John Ferlan -
Viktor Mihajlovski