[PATCH] [TEST] Modify ComputerSystem/04_defineStartVS.py and VSSDC.01 to call new GetInstance
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1223891987 25200 # Node ID 7cf9ca34ef7b5f8a9f3762f68185c6bd42252e67 # Parent c7eaf17bd591f313b93ff2b2087cee11b25789e0 [TEST] Modify ComputerSystem/04_defineStartVS.py and VSSDC.01 to call new GetInstance Signed-off-by: Guolian Yun <yunguol@cn.ibm.com> diff -r c7eaf17bd591 -r 7cf9ca34ef7b suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py --- a/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py Fri Oct 10 03:08:12 2008 -0700 +++ b/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py Mon Oct 13 02:59:47 2008 -0700 @@ -62,11 +62,12 @@ # otherwise. for i in range(1, (timeout + 1)): sleep(1) + cs_class = get_typed_class(options.virt, 'ComputerSystem') keys = { 'Name' : test_dom, - 'CreationClassName' : get_typed_class(options.virt, 'ComputerSystem') + 'CreationClassName' : cs_class } - cs = enumclass.getInstance(options.ip, 'ComputerSystem', keys, options.virt) + cs = enumclass.GetInstance(options.ip, cs_class, keys) if cs.Name != test_dom: Globals.logger.error("VS %s is not defined" % test_dom) break diff -r c7eaf17bd591 -r 7cf9ca34ef7b suites/libvirt-cim/cimtest/VirtualSystemSettingDataComponent/01_forward.py --- a/suites/libvirt-cim/cimtest/VirtualSystemSettingDataComponent/01_forward.py Fri Oct 10 03:08:12 2008 -0700 +++ b/suites/libvirt-cim/cimtest/VirtualSystemSettingDataComponent/01_forward.py Mon Oct 13 02:59:47 2008 -0700 @@ -146,10 +146,7 @@ vssd_cn = get_typed_class(options.virt, 'VirtualSystemSettingData') try: - vssd = enumclass.getInstance(options.ip, \ - 'VirtualSystemSettingData', \ - key_list, \ - options.virt) + vssd = enumclass.GetInstance(options.ip, vssd_cn, key_list) if vssd is None: logger.error("VSSD instance for %s not found" % test_dom) cxml.undefine(options.ip)
+1 for me. yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1223891987 25200 # Node ID 7cf9ca34ef7b5f8a9f3762f68185c6bd42252e67 # Parent c7eaf17bd591f313b93ff2b2087cee11b25789e0 [TEST] Modify ComputerSystem/04_defineStartVS.py and VSSDC.01 to call new GetInstance
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
diff -r c7eaf17bd591 -r 7cf9ca34ef7b suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py --- a/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py Fri Oct 10 03:08:12 2008 -0700 +++ b/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py Mon Oct 13 02:59:47 2008 -0700 @@ -62,11 +62,12 @@ # otherwise. for i in range(1, (timeout + 1)): sleep(1) + cs_class = get_typed_class(options.virt, 'ComputerSystem') keys = { 'Name' : test_dom, - 'CreationClassName' : get_typed_class(options.virt, 'ComputerSystem') + 'CreationClassName' : cs_class } - cs = enumclass.getInstance(options.ip, 'ComputerSystem', keys, options.virt) + cs = enumclass.GetInstance(options.ip, cs_class, keys) if cs.Name != test_dom: Globals.logger.error("VS %s is not defined" % test_dom) break diff -r c7eaf17bd591 -r 7cf9ca34ef7b suites/libvirt-cim/cimtest/VirtualSystemSettingDataComponent/01_forward.py --- a/suites/libvirt-cim/cimtest/VirtualSystemSettingDataComponent/01_forward.py Fri Oct 10 03:08:12 2008 -0700 +++ b/suites/libvirt-cim/cimtest/VirtualSystemSettingDataComponent/01_forward.py Mon Oct 13 02:59:47 2008 -0700 @@ -146,10 +146,7 @@ vssd_cn = get_typed_class(options.virt, 'VirtualSystemSettingData')
try: - vssd = enumclass.getInstance(options.ip, \ - 'VirtualSystemSettingData', \ - key_list, \ - options.virt) + vssd = enumclass.GetInstance(options.ip, vssd_cn, key_list) if vssd is None: logger.error("VSSD instance for %s not found" % test_dom) cxml.undefine(options.ip)
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1223891987 25200 # Node ID 7cf9ca34ef7b5f8a9f3762f68185c6bd42252e67 # Parent c7eaf17bd591f313b93ff2b2087cee11b25789e0 [TEST] Modify ComputerSystem/04_defineStartVS.py and VSSDC.01 to call new GetInstance
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
diff -r c7eaf17bd591 -r 7cf9ca34ef7b suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py --- a/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py Fri Oct 10 03:08:12 2008 -0700 +++ b/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.py Mon Oct 13 02:59:47 2008 -0700
This test fails for me with Xen: ComputerSystem - 04_defineStartVS.py: FAIL ERROR - Failed to Start the dom: domguest It fails without your patch applied, so I've applied this patch. However, can you take a look to see why it might be failing? Thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
libvirt-cim-bounces@redhat.com wrote on 2008-10-14 04:03:46:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1223891987 25200 # Node ID 7cf9ca34ef7b5f8a9f3762f68185c6bd42252e67 # Parent c7eaf17bd591f313b93ff2b2087cee11b25789e0 [TEST] Modify ComputerSystem/04_defineStartVS.py and VSSDC.01 to call new GetInstance
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
diff -r c7eaf17bd591 -r 7cf9ca34ef7b suites/libvirt- cim/cimtest/ComputerSystem/04_defineStartVS.py --- a/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.
+++ b/suites/libvirt-cim/cimtest/ComputerSystem/04_defineStartVS.
yunguol@cn.ibm.com wrote: py Fri Oct 10 03:08:12 2008 -0700 py Mon Oct 13 02:59:47 2008 -0700
This test fails for me with Xen:
ComputerSystem - 04_defineStartVS.py: FAIL ERROR - Failed to Start the dom: domguest
It fails without your patch applied, so I've applied this patch. However, can you take a look to see why it might be failing?
I don't get any updates from repository. Would you please check this? =) Thanks!
Thanks!
-- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
It fails without your patch applied, so I've applied this patch. However, can you take a look to see why it might be failing?
I don't get any updates from repository. Would you please check this? =)
Thanks!
The updates are in the tree now. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (4)
-
Deepti B Kalakeri -
Guo Lian Yun -
Kaitlin Rupert -
yunguol＠cn.ibm.com