[PATCH] SDC doesn't support specific RASD classes

# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1196451201 28800 # Node ID d5af3e219c22e8b32de64c69a29aea970ab6a9a4 # Parent 6515e4a1c90bba936fa1a15ddf2f501491e16fb5 SDC doesn't support specific RASD classes. Instead of using Xen_ResourceAllocationSettingData / KVM_ResourceAllocationSettingData in the resource_allocation_setting_data list, we should use specific RASD class names so that specifying a specific RASD class as a result class is supported. I also missed this one while reviewing Heidi's patches. Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com> diff -r 6515e4a1c90b -r d5af3e219c22 src/Virt_SettingsDefineCapabilities.c --- a/src/Virt_SettingsDefineCapabilities.c Fri Nov 30 10:43:37 2007 -0800 +++ b/src/Virt_SettingsDefineCapabilities.c Fri Nov 30 11:33:21 2007 -0800 @@ -847,8 +847,14 @@ char* group_component[] = { }; char* part_component[] = { - "Xen_ResourceAllocationSettingData", - "KVM_ResourceAllocationSettingData", + "Xen_DiskResourceAllocationSettingData", + "Xen_MemResourceAllocationSettingData", + "Xen_NetResourceAllocationSettingData", + "Xen_ProcResourceAllocationSettingData", + "KVM_DiskResourceAllocationSettingData", + "KVM_MemResourceAllocationSettingData", + "KVM_NetResourceAllocationSettingData", + "KVM_ProcResourceAllocationSettingData", NULL };

KR> # HG changeset patch KR> # User Kaitlin Rupert <karupert@us.ibm.com> KR> # Date 1196451201 28800 KR> # Node ID d5af3e219c22e8b32de64c69a29aea970ab6a9a4 KR> # Parent 6515e4a1c90bba936fa1a15ddf2f501491e16fb5 KR> SDC doesn't support specific RASD classes. KR> Instead of using Xen_ResourceAllocationSettingData / KR> KVM_ResourceAllocationSettingData in the KR> resource_allocation_setting_data list, we should use specific RASD KR> class names so that specifying a specific RASD class as a result KR> class is supported. Good call. Applied. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com

Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1196451201 28800 # Node ID d5af3e219c22e8b32de64c69a29aea970ab6a9a4 # Parent 6515e4a1c90bba936fa1a15ddf2f501491e16fb5 SDC doesn't support specific RASD classes.
Instead of using Xen_ResourceAllocationSettingData / KVM_ResourceAllocationSettingData in the resource_allocation_setting_data list, we should use specific RASD class names so that specifying a specific RASD class as a result class is supported.
Great :) !
I also missed this one while reviewing Heidi's patches. Me too :( ... ooops.
-- Regards Heidi Eckhart Software Engineer Linux Technology Center - Open Hypervisor heidieck@linux.vnet.ibm.com ************************************************** IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschaeftsfuehrung: Herbert Kircher Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
participants (3)
-
Dan Smith
-
Heidi Eckhart
-
Kaitlin Rupert