[PATCH] Make isMigratable return true if it makes it all the way through the checks,

# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1206551684 25200 # Node ID 19f1da7d9a42f35ab345699b36e22d6981b26342 # Parent c2b027700cb7a3075a9b9f56acd6d52cbd1f6fdf Make isMigratable return true if it makes it all the way through the checks, false otherwise. These should be independent of the return code and the status, which the patch fixes. Signed-off-by: Dan Smith <danms@us.ibm.com> diff -r c2b027700cb7 -r 19f1da7d9a42 src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Tue Mar 25 13:45:01 2008 -0700 +++ b/src/Virt_VSMigrationService.c Wed Mar 26 10:14:44 2008 -0700 @@ -543,7 +543,7 @@ static CMPIStatus vs_migratable(const CM CMPIStatus s; virConnectPtr conn = NULL; virConnectPtr dconn = NULL; - uint32_t retcode = 1; + uint32_t retcode = SVPC_RETURN_COMPLETED; CMPIBoolean isMigratable = 0; uint16_t type; virDomainPtr dom = NULL; @@ -598,14 +598,13 @@ static CMPIStatus vs_migratable(const CM goto out; } - retcode = CIM_SVPC_RETURN_COMPLETED; + isMigratable = 1; cu_statusf(_BROKER, &s, CMPI_RC_OK, ""); out: CMReturnData(results, (CMPIValue *)&retcode, CMPI_uint32); - isMigratable = (retcode == 0); CMAddArg(argsout, "IsMigratable", (CMPIValue *)&isMigratable, CMPI_boolean);

Dan Smith wrote:
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1206551684 25200 # Node ID 19f1da7d9a42f35ab345699b36e22d6981b26342 # Parent c2b027700cb7a3075a9b9f56acd6d52cbd1f6fdf Make isMigratable return true if it makes it all the way through the checks, false otherwise. These should be independent of the return code and the status, which the patch fixes.
Signed-off-by: Dan Smith <danms@us.ibm.com>
Not a huge fan of this whole rc for the check and result of the check thing, but CIM can take the heat for that one. +1 -- -Jay
participants (2)
-
Dan Smith
-
Jay Gagnon