[PATCH 0 of 3] Changes from Fedora review
These are changes I had to make to get libcmpiutil to pass the Fedora review cycle.
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1195604848 28800 # Node ID 6ef1c42262ed980483a700f0d9cf8ba55c120977 # Parent bf54de6af2e210bef57d74cf12e4872f6ba2da4f [CU] Fix a compiler warning that was blocking Fedora 9 compiles Signed-off-by: Dan Smith <danms@us.ibm.com> diff -r bf54de6af2e2 -r 6ef1c42262ed std_association.c --- a/std_association.c Tue Nov 20 16:24:27 2007 -0800 +++ b/std_association.c Tue Nov 20 16:27:28 2007 -0800 @@ -76,7 +76,7 @@ static bool match_class(const CMPIBroker } static CMPIStatus filter_results(struct inst_list *list, - char *ns, + const char *ns, const char *filter_class, const CMPIBroker *broker) {
On Tue, Nov 20, 2007 at 04:29:07PM -0700, Dan Smith wrote:
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1195604848 28800 # Node ID 6ef1c42262ed980483a700f0d9cf8ba55c120977 # Parent bf54de6af2e210bef57d74cf12e4872f6ba2da4f [CU] Fix a compiler warning that was blocking Fedora 9 compiles
makes sense to me, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1195604916 28800 # Node ID bb19bc08877d11b33d0296a9c67a5149be676fd2 # Parent 6ef1c42262ed980483a700f0d9cf8ba55c120977 [CU] Fix parallel make Signed-off-by: Dan Smith <danms@us.ibm.com> diff -r 6ef1c42262ed -r bb19bc08877d Makefile.am --- a/Makefile.am Tue Nov 20 16:27:28 2007 -0800 +++ b/Makefile.am Tue Nov 20 16:28:36 2007 -0800 @@ -21,6 +21,7 @@ libcmpiutil_la_SOURCES = args_util.c ins debug_util.c libcmpiutil_la_CFLAGS = $(CFLAGS) $(CFLAGS_STRICT) libcmpiutil_la_LIBADD = +libcmpiutil_la_DEPENDENCIES = AM_LFLAGS = -Peo_parse_ AM_YFLAGS = -d -p eo_parse_ @@ -28,6 +29,7 @@ if build_eoparser if build_eoparser LEX_OUTPUT_ROOT = lex.eo_parse_ libcueoparser_la_SOURCES = eo_util_parser.y eo_util_lexer.l eo_parser.c +libcmpiutil_la_DEPENDENCIES += libcueoparser.la libcmpiutil_la_LIBADD += -lcueoparser EOPARSER = libcueoparser.la BUILT_SOURCES = eo_util_lexer.c eo_util_parser.c eo_util_parser.h
On Tue, Nov 20, 2007 at 04:29:08PM -0700, Dan Smith wrote:
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1195604916 28800 # Node ID bb19bc08877d11b33d0296a9c67a5149be676fd2 # Parent 6ef1c42262ed980483a700f0d9cf8ba55c120977 [CU] Fix parallel make
Seems to be one of the .la dependancies forgotten in the previous round, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1195604916 28800 # Node ID 040163ea48140857e410f1ef0e97a16d37a0510f # Parent bb19bc08877d11b33d0296a9c67a5149be676fd2 Bump RPM release to 4, after Fedora review cycles Signed-off-by: Dan Smith <danms@us.ibm.com> diff -r bb19bc08877d -r 040163ea4814 libcmpiutil.spec.in --- a/libcmpiutil.spec.in Tue Nov 20 16:28:36 2007 -0800 +++ b/libcmpiutil.spec.in Tue Nov 20 16:28:36 2007 -0800 @@ -3,7 +3,7 @@ Summary: CMPI Utility Library Summary: CMPI Utility Library Name: libcmpiutil Version: @PACKAGE_VERSION@ -Release: 1%{?dist}%{?extra_release} +Release: 4%{?dist}%{?extra_release} License: LGPLv2+ Group: Development/Libraries Source: libcmpiutil-%{version}.tar.gz
On Tue, Nov 20, 2007 at 04:29:09PM -0700, Dan Smith wrote:
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1195604916 28800 # Node ID 040163ea48140857e410f1ef0e97a16d37a0510f # Parent bb19bc08877d11b33d0296a9c67a5149be676fd2 Bump RPM release to 4, after Fedora review cycles
Signed-off-by: Dan Smith <danms@us.ibm.com>
diff -r bb19bc08877d -r 040163ea4814 libcmpiutil.spec.in --- a/libcmpiutil.spec.in Tue Nov 20 16:28:36 2007 -0800 +++ b/libcmpiutil.spec.in Tue Nov 20 16:28:36 2007 -0800 @@ -3,7 +3,7 @@ Summary: CMPI Utility Library Summary: CMPI Utility Library Name: libcmpiutil Version: @PACKAGE_VERSION@ -Release: 1%{?dist}%{?extra_release} +Release: 4%{?dist}%{?extra_release}
For the packages I maintain, I don't bother updating the RPM releases upstream, that's a distib specific information, and doesn't make much sense out of that context. I would just keep 1 upstream, and just update the Changelog (of the spec) on each new version. Then whoever does the packaging for a given distro handles those tiny details :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Dan Smith -
Daniel Veillard