Questions about Libvirt-CIM classes and Cimtest items
Hi, I make a simple comparison CIM classes list between Libvirt-CIM, Cimtest and DSP10xx specifications. (See Summary_number_of_classes.ods) According to this summary, I come up with two questions. I would appreciate if you answer the questions. (1)If Libvirt-CIM fills CIM Schema specifications, it needs to add more 11 classes(*1). (2)If Cimtest fills both Libvirt-CIM classes and CIM Schema specifications, it needs to add more about 100 test items(*2). What do you think? *1:See red cells in ods file. *2:See red and yellow cells in ods files. There are 5 test items a Cimtest class on average. 5(items/class) * (14+11)(classes) = 100(items) -- Toshifumi Fujimura.
Sorry, "Summary_number_of_classes.ods" is "OpenOffice.org Calc" file. -- Toshifumi Fujimura.
Toshifumi Fujimura wrote:
Hi,
I make a simple comparison CIM classes list between Libvirt-CIM, Cimtest and DSP10xx specifications. (See Summary_number_of_classes.ods) According to this summary, I come up with two questions. I would appreciate if you answer the questions.
(1)If Libvirt-CIM fills CIM Schema specifications, it needs to add more 11 classes(*1). (2)If Cimtest fills both Libvirt-CIM classes and CIM Schema specifications, it needs to add more about 100 test items(*2).
What do you think?
Yes, I think this is a reasonable estimate to get basic coverage. You can take a look at our to-do list: http://wiki.libvirt.org/page/Cimtest_todo There's a number of test case ideas mentioned there. Of course, there are numerous others that aren't mentioned there.
*1:See red cells in ods file. *2:See red and yellow cells in ods files. There are 5 test items a Cimtest class on average. 5(items/class) * (14+11)(classes) = 100(items)
I've created a wiki page that lists the classes we support and what tests cover those classes: http://wiki.libvirt.org/page/Cimtest_test_info Here's the list of classes currently implemented that don't have test cases: -ComputerSystemMigrationIndication -ConcreteComponent -DisplayController -KVMRedirectionSAP -PointingDevice (patch under review) -GraphicsResourceAllocationSettingData -InputResourceAllocationSettingData (patch under review) -ServiceAffectsElement My list is slightly shorter than your's - let me know if you think I've missed something. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
Hi, Thanks for a creating wiki page. I have three questions about this wiki page. I would appreciate if you answer the questions. (1)The class "AllocationCapabilities" exists on Libvirt-CIM(revision: 738). But it doesn't in this wiki page. Is this forgotten? (2)The test directory "VirtualSystemSettingDataComponent" exists on Cimtest(revision: 488). But from this wiki, it is not used as the test of class "VirtualSystemSettingDataComponent". Is this forgotten? (3) From "DSP1059" spec,it seems that some classes don't define on DSP1059. For example,"ConcreteComponent", "DiskPool", "DisplayController", "ElementAllocatedFromPool"... But these classes define in this wiki page. And in the same, from "DSP1042" spec, it seems that some classes don't define on DSP1042. For exmaple, "ComputerSystemIndication", "EnabledLogicalElementCapabilities", "HostSystem" and "SettingsDefineCapabilities". But these classes define in this wiki page. Why? -- Toshifumi Fujimura.
Toshifumi Fujimura wrote:
Hi,
Thanks for a creating wiki page. I have three questions about this wiki page. I would appreciate if you answer the questions.
Thanks for catching these items! I created the wiki page rather quickly yesterday - I have a few errors on it.
(1)The class "AllocationCapabilities" exists on Libvirt-CIM(revision: 738). But it doesn't in this wiki page. Is this forgotten?
Yes, I missed this one. It's on the wiki page now.
(2)The test directory "VirtualSystemSettingDataComponent" exists on Cimtest(revision: 488). But from this wiki, it is not used as the test of class "VirtualSystemSettingDataComponent". Is this forgotten?
This directory is used for the VirtualSystemSettingDataComponent class. The VirtualSystemSettingDataComponent class originally said VirtualSystemSnapshotServiceCapabilities, which is a typo. The wiki is updated with the proper class.
(3) From "DSP1059" spec,it seems that some classes don't define on DSP1059. For example,"ConcreteComponent", "DiskPool", "DisplayController", "ElementAllocatedFromPool"... But these classes define in this wiki page.
ConcreteComponent - this is shown in the diagram on page 10 in DSP1059 (GDRVP). It's also mentioned in DSP1042 (SVP) and DSP1041 (ResourceAllocationProfile). We don't advertise DSP1041, although we probably should. The class is discussed in detail in DSP1041. DiskPool - this is a subclass of ResourcePool. ResourcePool is mentioned in DSP1059, DSP1042, and DSP1041. DisplayController - this is a subclass of LogicalDevice. LogicalDevice is in the diagram on page 10 in DSP1059. It's also mentioned in DSP1042 and DSP1041. The class is discussed in detail in DSP1041. ElementAllocatedFromPool - is in the diagram on page 10 in DSP1059. It's also mentioned in DSP1042 and DSP1041. The class is discussed in detail in DSP1041. Two things should probably be done: 1) Update the RegisteredProfile provider to include DSP1041. 2) Update the wiki to include which profiles the class is mentioned in and which profile describes the class in detail
And in the same, from "DSP1042" spec, it seems that some classes don't define on DSP1042. For exmaple, "ComputerSystemIndication", "EnabledLogicalElementCapabilities", "HostSystem" and "SettingsDefineCapabilities". But these classes define in this wiki page.
Why?
For these, this is a similar issue - these classes are referenced in multiple profiles. I'll see if I can fix this up today so that the table is a little more clear. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
Two things should probably be done: 1) Update the RegisteredProfile provider to include DSP1041. 2) Update the wiki to include which profiles the class is mentioned in and which profile describes the class in detail
Updated the wiki with a little more profile info.
And in the same, from "DSP1042" spec, it seems that some classes don't define on DSP1042. For exmaple, "ComputerSystemIndication", "EnabledLogicalElementCapabilities", "HostSystem" and "SettingsDefineCapabilities". But these classes define in this wiki page.
Why?
For these, this is a similar issue - these classes are referenced in multiple profiles. I'll see if I can fix this up today so that the table is a little more clear.
I forgot to mention - HostSystem is a subclass of ComputerSystem (which is a subclass of System). In most DMTF schema diagrams, you'll see System used to represent the host machine and ComputerSystem used to represent the virtual system. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (2)
-
Kaitlin Rupert -
Toshifumi Fujimura