[PATCH] Fix Virt_SettingsDefineCapabilities provider install issue
# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1208479105 25200 # Node ID e415e98ec3b386ecff91449696a71f5d7607ca6a # Parent a3c65a655c61fe82b056a590cdaef5356626e3e6 Fix Virt_SettingsDefineCapabilities provider install issue. Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com> diff -r a3c65a655c61 -r e415e98ec3b3 src/Makefile.am --- a/src/Makefile.am Thu Apr 17 14:57:07 2008 -0700 +++ b/src/Makefile.am Thu Apr 17 17:38:25 2008 -0700 @@ -121,13 +121,6 @@ -lVirt_VirtualSystemManagementService \ -lVirt_VSMigrationService -libVirt_SettingsDefineCapabilities_la_DEPENDENCIES = libVirt_RASD.la libVirt_DevicePool.la libVirt_VSMigrationCapabilities.la libVirt_VSMigrationSettingData.la -libVirt_SettingsDefineCapabilities_la_SOURCES = Virt_SettingsDefineCapabilities.c -libVirt_SettingsDefineCapabilities_la_LIBADD = -lVirt_RASD \ - -lVirt_DevicePool \ - -lVirt_VSMigrationCapabilities \ - -lVirt_VSMigrationSettingData - libVirt_RegisteredProfile_la_SOURCES = Virt_RegisteredProfile.c libVirt_HostedResourcePool_la_DEPENDENCIES = libVirt_DevicePool.la libVirt_HostSystem.la @@ -181,3 +174,11 @@ libVirt_VirtualSystemSnapshotServiceCapabilities_la_DEPENDENCIES = libVirt_VirtualSystemSnapshotServiceCapabilities_la_SOURCES = Virt_VirtualSystemSnapshotServiceCapabilities.c libVirt_VirtualSystemSnapshotServiceCapabilities_la_LIBADD = + +libVirt_SettingsDefineCapabilities_la_DEPENDENCIES = libVirt_RASD.la libVirt_DevicePool.la libVirt_VSMigrationCapabilities.la libVirt_VSMigrationSettingData.la +libVirt_SettingsDefineCapabilities_la_SOURCES = Virt_SettingsDefineCapabilities.c +libVirt_SettingsDefineCapabilities_la_LIBADD = -lVirt_RASD \ + -lVirt_DevicePool \ + -lVirt_VSMigrationCapabilities \ + -lVirt_VSMigrationSettingData +
Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1208479105 25200 # Node ID e415e98ec3b386ecff91449696a71f5d7607ca6a # Parent a3c65a655c61fe82b056a590cdaef5356626e3e6 Fix Virt_SettingsDefineCapabilities provider install issue.
This issue keeps cropping up. It seems like automake should handle this properly, but it doesn't. Is it worth re-ording the Makefile so that things are listed based on their dependencies? -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
KR> # HG changeset patch KR> # User Kaitlin Rupert <karupert@us.ibm.com> KR> # Date 1208479105 25200 KR> # Node ID e415e98ec3b386ecff91449696a71f5d7607ca6a KR> # Parent a3c65a655c61fe82b056a590cdaef5356626e3e6 KR> Fix Virt_SettingsDefineCapabilities provider install issue. Can you provide a little more detail here? Reordering the variables should not (AFAIK) have any effect on the order in which things get processed or installed. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com
Dan Smith wrote:
KR> # HG changeset patch KR> # User Kaitlin Rupert <karupert@us.ibm.com> KR> # Date 1208479105 25200 KR> # Node ID e415e98ec3b386ecff91449696a71f5d7607ca6a KR> # Parent a3c65a655c61fe82b056a590cdaef5356626e3e6 KR> Fix Virt_SettingsDefineCapabilities provider install issue.
Can you provide a little more detail here? Reordering the variables should not (AFAIK) have any effect on the order in which things get processed or installed.
The issue is that Virt_SettingsDefineCapabilities isn't being installed on the first pass. So you'll have to run make install twice (and the rpm install will miss it completely). However, I retested this patch again today, and it doesn't solve the problem. So please ignore this patch =) -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (2)
-
Dan Smith -
Kaitlin Rupert