[PATCH] Fix connection leak introduced in patch 1119
# HG changeset patch # User Sharad Mishra <snmishra@us.ibm.com> # Date 1311624862 25200 # Node ID 87404863f9a402eb1a59ff717d93caa75c50b29c # Parent 7cb42b369d3776c9d727402ba0198eea573d0d40 Fix connection leak introduced in patch 1119. Signed-off-by: Sharad Mishra <snmishra@us.ibm.com> diff -r 7cb42b369d37 -r 87404863f9a4 src/Virt_RASD.c --- a/src/Virt_RASD.c Wed Jul 20 06:43:06 2011 -0700 +++ b/src/Virt_RASD.c Mon Jul 25 13:14:22 2011 -0700 @@ -349,6 +349,9 @@ (CMPIValue *)dev->dev.disk.cache, CMPI_chars); + virStoragePoolFree(pool); + virStorageVolFree(vol); + virConnectClose(conn); return s; }
(x86_64) libvirt-cim-0.5.14-1 tog-pegasus-2.11.0-1 libvirt-0.8.7-18 Before: # netstat -na | grep -v LISTENING | grep -c libvirt-sock 0 After: # netstat -na | grep -v LISTENING | grep -c libvirt-sock 0 -> no connection leaks. +1 and pushed! See attached run report for additional details: The results look *much* better with this patch. I only see three other 'interesting' issues: 1) Computer System Indication - needs investigation [priority = ?] 2) Profile assoc failures - libvirt-cim fix in progress [prority = high] 3) PoolID mismatches - side effect of fix 1119, which was expected. Fix will be in cimtest [priority = low] I'm working on a fix for #2 now. On 07/25/2011 04:15 PM, Sharad Mishra wrote:
# HG changeset patch # User Sharad Mishra<snmishra@us.ibm.com> # Date 1311624862 25200 # Node ID 87404863f9a402eb1a59ff717d93caa75c50b29c # Parent 7cb42b369d3776c9d727402ba0198eea573d0d40 Fix connection leak introduced in patch 1119.
Signed-off-by: Sharad Mishra<snmishra@us.ibm.com>
diff -r 7cb42b369d37 -r 87404863f9a4 src/Virt_RASD.c --- a/src/Virt_RASD.c Wed Jul 20 06:43:06 2011 -0700 +++ b/src/Virt_RASD.c Mon Jul 25 13:14:22 2011 -0700 @@ -349,6 +349,9 @@ (CMPIValue *)dev->dev.disk.cache, CMPI_chars);
+ virStoragePoolFree(pool); + virStorageVolFree(vol); + virConnectClose(conn); return s; }
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Chip Vincent Open Virtualization IBM Linux Technology Center cvincent@linux.vnet.ibm.com
participants (2)
-
Chip Vincent -
Sharad Mishra