[PATCH] [TEST] Change KVM default network type to bridge
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1207647488 25200 # Node ID 6ec8fdc414f8c86160a8c578465901c77e8cfcc0 # Parent 851b6729397e782b7ac6fbadee849ee7da9b16d3 [TEST] Change KVM default network type to bridge The original 'user' is not listed in provider code for valid check. (Consider update provider, too?) This fix the SettingsDefine failure on recent KVM run. Signed-off-by: Guolian Yun <yunguol@cn.ibm.com> diff -r 851b6729397e -r 6ec8fdc414f8 suites/libvirt-cim/lib/XenKvmLib/vxml.py --- a/suites/libvirt-cim/lib/XenKvmLib/vxml.py Mon Apr 07 08:27:46 2008 -0700 +++ b/suites/libvirt-cim/lib/XenKvmLib/vxml.py Tue Apr 08 02:38:08 2008 -0700 @@ -501,9 +501,10 @@ class KVMXML(VirtXML): self.add_sub_node(disk, 'source', file=disk_img) self.add_sub_node(disk, 'target', dev=disk_dev) - interface = self.add_sub_node(devices, 'interface', type='user') + interface = self.add_sub_node(devices, 'interface', type='bridge') self.add_sub_node(interface, 'mac', address=net_mac) - + self.set_bridge(CIM_IP) + def set_emulator(self, emu): return self._set_emulator(emu)
Guo Lian Yun wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1207647488 25200 # Node ID 6ec8fdc414f8c86160a8c578465901c77e8cfcc0 # Parent 851b6729397e782b7ac6fbadee849ee7da9b16d3 [TEST] Change KVM default network type to bridge
The original 'user' is not listed in provider code for valid check. (Consider update provider, too?)
This is a good change, but it would also be good to have a separate test case that uses "user" as the network type. The test case will fail for now, which will allow us to keep track of the issue. Would you be interested in writing such a case? -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
libvirt-cim-bounces@redhat.com wrote on 2008-04-09 01:47:14:
Guo Lian Yun wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1207647488 25200 # Node ID 6ec8fdc414f8c86160a8c578465901c77e8cfcc0 # Parent 851b6729397e782b7ac6fbadee849ee7da9b16d3 [TEST] Change KVM default network type to bridge
The original 'user' is not listed in provider code for valid check. (Consider update provider, too?)
This is a good change, but it would also be good to have a separate test case that uses "user" as the network type. The test case will fail for now, which will allow us to keep track of the issue.
Would you be interested in writing such a case?
I've sent a patch for this, which includes a separate test case that uses 'user' as network type and related helper functions.
-- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
participants (2)
-
Guo Lian Yun -
Kaitlin Rupert