[PATCH] Fix bizarre crash in VSMigrationService

# HG changeset patch # User Jay Gagnon <grendel@linux.vnet.ibm.com> # Date 1205334578 14400 # Node ID 24baa607951031ef22b5263742135bef9f24d29b # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 Fix bizarre crash in VSMigrationService Apparently I was the only one seeing this, but I hit a very strange bug in Virt_VSMigrationService. It would just totally implode whenever I tried to migrate a system. It was eventually tracked down to the transport member of the migration_job struct; for some reason if that member (which we don't even use anymore) is removed everything works perfectly. This might bear more investigation, but for the time being the fix should at least be put in. Signed-off-by: Jay Gagnon <grendel@linux.vnet.ibm.com> diff -r b739fc9b1332 -r 24baa6079510 src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Tue Mar 11 13:28:04 2008 -0700 +++ b/src/Virt_VSMigrationService.c Wed Mar 12 11:09:38 2008 -0400 @@ -64,7 +64,6 @@ struct migration_job { char *ref_cn; char *ref_ns; uint16_t type; - uint16_t transport; char uuid[33]; };

Jay Gagnon wrote:
# HG changeset patch # User Jay Gagnon <grendel@linux.vnet.ibm.com> # Date 1205334578 14400 # Node ID 24baa607951031ef22b5263742135bef9f24d29b # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 Fix bizarre crash in VSMigrationService
Apparently I was the only one seeing this, but I hit a very strange bug in Virt_VSMigrationService. It would just totally implode whenever I tried to migrate a system. It was eventually tracked down to the transport member of the migration_job struct; for some reason if that member (which we don't even use anymore) is removed everything works perfectly. This might bear more investigation, but for the time being the fix should at least be put in.
Signed-off-by: Jay Gagnon <grendel@linux.vnet.ibm.com>
Sorry, totally forgot to send this out yesterday. Or most of today. Anyway, there it is. -- -Jay

Jay Gagnon wrote:
# HG changeset patch # User Jay Gagnon <grendel@linux.vnet.ibm.com> # Date 1205334578 14400 # Node ID 24baa607951031ef22b5263742135bef9f24d29b # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 Fix bizarre crash in VSMigrationService
Apparently I was the only one seeing this, but I hit a very strange bug in Virt_VSMigrationService. It would just totally implode whenever I tried to migrate a system. It was eventually tracked down to the transport member of the migration_job struct; for some reason if that member (which we don't even use anymore) is removed everything works perfectly. This might bear more investigation, but for the time being the fix should at least be put in.
Signed-off-by: Jay Gagnon <grendel@linux.vnet.ibm.com>
diff -r b739fc9b1332 -r 24baa6079510 src/Virt_VSMigrationService.c
I'm not sure why this fixes your problem, but it's definitely not needed anymore. +1 -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (2)
-
Jay Gagnon
-
Kaitlin Rupert