[PATCH] Remove call to virConnectClose() in set_infstore_migration_flag()
# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1250733416 25200 # Node ID 6fc5000bc5c33ffed10f71bf87a136da3fe2e036 # Parent 279db79737df790e7d10668e155bb7bcaf80254c Remove call to virConnectClose() in set_infstore_migration_flag() We don't want to close the connection here since it is used later on in migrate_do(). This can lead to a seg fault or a invalid free. Also, it means our connection object is invalid, so any queries we do to libvirt will fail. Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com> diff -r 279db79737df -r 6fc5000bc5c3 src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Tue Aug 18 11:18:19 2009 -0700 +++ b/src/Virt_VSMigrationService.c Wed Aug 19 18:56:56 2009 -0700 @@ -1298,7 +1298,6 @@ out: virDomainFree(dom); - virConnectClose(conn); return ret; }
+1 On 08/19/2009 10:57 PM, Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert<karupert@us.ibm.com> # Date 1250733416 25200 # Node ID 6fc5000bc5c33ffed10f71bf87a136da3fe2e036 # Parent 279db79737df790e7d10668e155bb7bcaf80254c Remove call to virConnectClose() in set_infstore_migration_flag()
We don't want to close the connection here since it is used later on in migrate_do(). This can lead to a seg fault or a invalid free. Also, it means our connection object is invalid, so any queries we do to libvirt will fail.
Signed-off-by: Kaitlin Rupert<karupert@us.ibm.com>
diff -r 279db79737df -r 6fc5000bc5c3 src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Tue Aug 18 11:18:19 2009 -0700 +++ b/src/Virt_VSMigrationService.c Wed Aug 19 18:56:56 2009 -0700 @@ -1298,7 +1298,6 @@
out: virDomainFree(dom); - virConnectClose(conn);
return ret; }
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Richard Maciel, MSc IBM Linux Technology Center rmaciel@linux.vnet.ibm.com
participants (2)
-
Kaitlin Rupert -
Richard Maciel