[PATCH 0/2] Address a couple of spec file issues
These patches resolve a couple of issues with the spec file. John Ferlan (2): spec: Replace the path to the tar.gz file spec: Fix capitalization for version check libvirt-cim.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1
Commit '07adabc2' seems to have inadvertently removed the path to the source ftp file added by commit '5412bf11'. --- libvirt-cim.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-cim.spec.in b/libvirt-cim.spec.in index 7b6221e..dbee4dc 100644 --- a/libvirt-cim.spec.in +++ b/libvirt-cim.spec.in @@ -6,7 +6,7 @@ Version: @PACKAGE_VERSION@ Release: 1%{?dist}%{?extra_release} License: LGPLv2+ Group: Development/Libraries -Source: libvirt-cim-%{version}.tar.gz +Source: ftp://libvirt.org/libvirt-cim/libvirt-cim-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root URL: http://libvirt.org/CIM/ Requires: libxml2 >= 2.6.0 -- 1.8.3.1
"Fedora" shouldn't have been capitalized in the check to use systemctl instead of /etc/init.d/tog-pegasus --- libvirt-cim.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-cim.spec.in b/libvirt-cim.spec.in index dbee4dc..d30c198 100644 --- a/libvirt-cim.spec.in +++ b/libvirt-cim.spec.in @@ -89,7 +89,7 @@ rm -fr $RPM_BUILD_ROOT %{_datadir}/%{name}/install_base_schema.sh %{_datadir}/%{name} -%if 0%{?Fedora} >= 17 || 0%{?rhel} >= 7 +%if 0%{?fedora} >= 17 || 0%{?rhel} >= 7 if [ "`systemctl is-active tog-pegasus.service`" = "active" ] then systemctl restart tog-pegasus.service -- 1.8.3.1
On 08/08/2013 06:19 PM, John Ferlan wrote:
These patches resolve a couple of issues with the spec file.
John Ferlan (2): spec: Replace the path to the tar.gz file spec: Fix capitalization for version check
libvirt-cim.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ping?
On 08/09/2013 12:19 AM, John Ferlan wrote:
These patches resolve a couple of issues with the spec file.
John Ferlan (2): spec: Replace the path to the tar.gz file spec: Fix capitalization for version check
libvirt-cim.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[Looks good to me.] Reviewed-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
participants (2)
-
John Ferlan -
Viktor Mihajlovski