[PATCH] [TEST] VirtCIM init for the LXC virt must also receive pae, acpi and apic param

# HG changeset patch # User Richard Maciel <rmaciel@linux.vnet.ibm.com> # Date 1259704363 7200 # Node ID 1c723b6b44a4a49f01395dc9f30249824e44b9ca # Parent 9445f602d8a8705743254f85ef426d284ab382d4 [TEST] VirtCIM init for the LXC virt must also receive pae, acpi and apic param Signed-off-by: Richard Maciel <rmaciel@linux.vnet.ibm.com> diff -r 9445f602d8a8 -r 1c723b6b44a4 suites/libvirt-cim/lib/XenKvmLib/vxml.py --- a/suites/libvirt-cim/lib/XenKvmLib/vxml.py Wed Nov 18 13:50:16 2009 -0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/vxml.py Tue Dec 01 19:52:43 2009 -0200 @@ -996,10 +996,13 @@ address="127.0.0.1", port_num='-1', keymap="en-us", irstype="mouse", btype="usb", vnc_passwd=None): VirtXML.__init__(self, 'lxc', test_dom, set_uuid(), mem, vcpus) - VirtCIM.__init__(self, 'LXC', test_dom, uuid, const.LXC_default_mp, - const.LXC_default_source, ntype, net_name, mac, vcpus, - mem, const.default_mallocunits, None, grstype, - address, port_num, keymap, irstype, btype, vnc_passwd) + # pae, acpi and apic parameters doesn't make sense here, so we statically set + # them to False (a.k.a. ignore them) + VirtCIM.__init__(self, 'LXC', test_dom, uuid, False, False, False, + const.LXC_default_mp, const.LXC_default_source, ntype, + net_name, mac, vcpus, mem, const.default_mallocunits, + None, grstype, address, port_num, keymap, irstype, btype, + vnc_passwd) self._os(const.LXC_init_path) self._devices(const.LXC_default_emulator, mac, ntype, net_name, const.LXC_default_tty) self.create_lxc_file(CIM_IP, const.LXC_init_path)

Richard Maciel wrote:
# HG changeset patch # User Richard Maciel <rmaciel@linux.vnet.ibm.com> # Date 1259704363 7200 # Node ID 1c723b6b44a4a49f01395dc9f30249824e44b9ca # Parent 9445f602d8a8705743254f85ef426d284ab382d4 [TEST] VirtCIM init for the LXC virt must also receive pae, acpi and apic param
Signed-off-by: Richard Maciel <rmaciel@linux.vnet.ibm.com>
diff -r 9445f602d8a8 -r 1c723b6b44a4 suites/libvirt-cim/lib/XenKvmLib/vxml.py --- a/suites/libvirt-cim/lib/XenKvmLib/vxml.py Wed Nov 18 13:50:16 2009 -0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/vxml.py Tue Dec 01 19:52:43 2009 -0200 @@ -996,10 +996,13 @@ address="127.0.0.1", port_num='-1', keymap="en-us", irstype="mouse", btype="usb", vnc_passwd=None): VirtXML.__init__(self, 'lxc', test_dom, set_uuid(), mem, vcpus) - VirtCIM.__init__(self, 'LXC', test_dom, uuid, const.LXC_default_mp, - const.LXC_default_source, ntype, net_name, mac, vcpus, - mem, const.default_mallocunits, None, grstype, - address, port_num, keymap, irstype, btype, vnc_passwd) + # pae, acpi and apic parameters doesn't make sense here, so we statically set
This line is over 80 characters. I know some of the other lines in vxml are over 80 characters - they were written prior to when we started enforcing a coding style. I'd love to see those lines fixed as well, but that's a subject for a different patch ;) -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (2)
-
Kaitlin Rupert
-
Richard Maciel