# HG changeset patch
# User Jim Fehlig <jfehlig(a)novell.com>
# Date 1218080112 21600
# Node ID 394f63c771edba0828e4aa0b48f7e9e2689b14c7
# Parent 9f2f9b117797907bfa2b89a499b4eb5bb62cd458
Fix logic that determines memory only or memory terminal snapshot
According to comments in Virt_VirtualSystemSnapshotService.h and
VirtualSystemSnapshotService.mof, it seems logic that determines
whether to do a restore uses wrong definition.
Signed-off-by: Jim Fehlig <jfehlig(a)novell.com>
diff -r 9f2f9b117797 -r 394f63c771ed src/Virt_VirtualSystemSnapshotService.c
--- a/src/Virt_VirtualSystemSnapshotService.c Mon Aug 04 11:57:27 2008 -0700
+++ b/src/Virt_VirtualSystemSnapshotService.c Wed Aug 06 21:35:12 2008 -0600
@@ -397,7 +397,7 @@ static CMPIStatus start_snapshot_job(con
}
ctx->save = (type != 0);
- ctx->restore = (type != VIR_VSSS_SNAPSHOT_MEM);
+ ctx->restore = (type != VIR_VSSS_SNAPSHOT_MEMT);
s = create_job(context, ref, ctx, &job);
Show replies by date
JF> - ctx->restore = (type != VIR_VSSS_SNAPSHOT_MEM);
JF> + ctx->restore = (type != VIR_VSSS_SNAPSHOT_MEMT);
The amount of time it took me to mentally process this change tells me
that this should be made a little clearer in the code at some point.
But, the fix is good. Thanks!
--
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms(a)us.ibm.com