[PATCH 0 of 2] Fixes to std_indication

# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1204313241 28800 # Node ID 7ac86cfb8d9344f583998d028ac235dcdeba657b # Parent b41ff87168e31ff492d98b3741b28c4fe0d7c089 Change "Indication" parameter name to something that isn't a CIM Qualifier Signed-off-by: Dan Smith <danms@us.ibm.com> diff -r b41ff87168e3 -r 7ac86cfb8d93 std_indication.c --- a/std_indication.c Thu Feb 28 13:55:49 2008 -0800 +++ b/std_indication.c Fri Feb 29 11:27:21 2008 -0800 @@ -121,7 +121,7 @@ static CMPIStatus raise(struct std_indic CMPIStatus s = {CMPI_RC_OK, NULL}; const char *ind_name = NULL; - if (cu_get_inst_arg(argsin, "Indication", &inst) != CMPI_RC_OK) { + if (cu_get_inst_arg(argsin, "TheIndication", &inst) != CMPI_RC_OK) { cu_statusf(ctx->brkr, &s, CMPI_RC_ERR_FAILED, "Could not get indication to raise"); @@ -370,7 +370,7 @@ CMPIStatus stdi_raise_indication(const C if (s.rc != CMPI_RC_OK) return s; - s = CMAddArg(argsin, "Indication", &ind, CMPI_instance); + s = CMAddArg(argsin, "TheIndication", &ind, CMPI_instance); if (s.rc != CMPI_RC_OK) return s;

Dan Smith wrote:
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1204313241 28800 # Node ID 7ac86cfb8d9344f583998d028ac235dcdeba657b # Parent b41ff87168e31ff492d98b3741b28c4fe0d7c089 Change "Indication" parameter name to something that isn't a CIM Qualifier
Signed-off-by: Dan Smith <danms@us.ibm.com>
I guess those people who haven't gone through what was required to figure out that we needed this are just going to have to trust us on this one; this is actually an important change. Thanks, pegasus. -- -Jay

# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1204313296 28800 # Node ID 282e58e792ba318b63329420d3918b02e9af7dd5 # Parent 7ac86cfb8d9344f583998d028ac235dcdeba657b Add missing error path Signed-off-by: Dan Smith <danms@us.ibm.com> diff -r 7ac86cfb8d93 -r 282e58e792ba std_indication.c --- a/std_indication.c Fri Feb 29 11:27:21 2008 -0800 +++ b/std_indication.c Fri Feb 29 11:28:16 2008 -0800 @@ -133,6 +133,7 @@ static CMPIStatus raise(struct std_indic cu_statusf(ctx->brkr, &s, CMPI_RC_ERR_FAILED, "Couldn't get indication name for enable check."); + goto out; } enabled = is_ind_enabled(ctx, ind_name, &s);

Dan Smith wrote:
# HG changeset patch # User Dan Smith <danms@us.ibm.com> # Date 1204313296 28800 # Node ID 282e58e792ba318b63329420d3918b02e9af7dd5 # Parent 7ac86cfb8d9344f583998d028ac235dcdeba657b Add missing error path
Signed-off-by: Dan Smith <danms@us.ibm.com>
Totally my bad here. Thanks! -- -Jay
participants (2)
-
Dan Smith
-
Jay Gagnon