[PATCH] [TEST]#4 Add "AllocationCapabilities" to associate with ECTP and skip KVM_RegisteredProfile association
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1236320248 28800 # Node ID b213dddc93404028075f10d7355c468ec8230274 # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7 [TEST]#4 Add "AllocationCapabilities" to associate with ECTP and skip KVM_RegisteredProfile association Updates from 3 to 4: Use a variable to assign revision value to be calculated for comparison Updates from 2 to 3: Add changeset instead of skip the verification of KVM_ResourceAllocation to ECTP for all the src versions Tested for KVM/LXC with current sources and rpm on Pegasus Signed-off-by: Guolian Yun<yunguol@cn.ibm.com> diff -r c6f7256013b9 -r b213dddc9340 suites/libvirt-cim/cimtest/ElementConforms/01_forward.py --- a/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Tue Mar 03 08:47:40 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Thu Mar 05 22:17:28 2009 -0800 @@ -53,7 +53,9 @@ test_dom = "domU" bug_sblim = '00007' libvirt_cim_ectp_changes = 686 -libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_ac_lower = 796 +libvirt_cim_ac_upper = 818 def init_managed_ele_values(server, virt): verify_ectp_list = {} @@ -63,7 +65,7 @@ curr_cim_rev, changeset = get_provider_version(virt, server) if curr_cim_rev >= libvirt_cim_ectp_changes: cn_names2 = ["VirtualSystemMigrationService", "DiskPool", "NetworkPool", - "ProcessorPool", "MemoryPool"] + "ProcessorPool", "MemoryPool", "AllocationCapabilities"] cn_names.extend(cn_names2) if curr_cim_rev >= libvirt_cim_input_graphics_ectp: cn_names.append("ConsoleRedirectionService") @@ -136,6 +138,11 @@ if profile.InstanceID not in unsupp_prof: profiles_instid_list.append(profile.InstanceID) + for prof_id in profiles_instid_list: + if prof_id == "CIM:DSP1041-ResourceAllocation-1.1.0c" and\ + libvirt_cim_ac_lower <= curr_cim_rev < libvirt_cim_ac_upper: + profiles_instid_list.remove(prof_id) + return status, profiles_instid_list @do_main(sup_types)
Any one review this patch? Thanks! libvirt-cim-bounces@redhat.com wrote on 2009-03-06 14:17:35:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1236320248 28800 # Node ID b213dddc93404028075f10d7355c468ec8230274 # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7 [TEST]#4 Add "AllocationCapabilities" to associate with ECTP and skip KVM_RegisteredProfile association
Updates from 3 to 4: Use a variable to assign revision value to be calculated for comparison
Updates from 2 to 3: Add changeset instead of skip the verification of KVM_ResourceAllocation to ECTP for all the src versions
Tested for KVM/LXC with current sources and rpm on Pegasus
Signed-off-by: Guolian Yun<yunguol@cn.ibm.com>
diff -r c6f7256013b9 -r b213dddc9340 suites/libvirt- cim/cimtest/ElementConforms/01_forward.py --- a/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Tue Mar 03 08:47:40 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Thu Mar 05 22:17:28 2009 -0800 @@ -53,7 +53,9 @@ test_dom = "domU" bug_sblim = '00007' libvirt_cim_ectp_changes = 686 -libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_ac_lower = 796 +libvirt_cim_ac_upper = 818
def init_managed_ele_values(server, virt): verify_ectp_list = {} @@ -63,7 +65,7 @@ curr_cim_rev, changeset = get_provider_version(virt, server) if curr_cim_rev >= libvirt_cim_ectp_changes: cn_names2 = ["VirtualSystemMigrationService", "DiskPool", "NetworkPool", - "ProcessorPool", "MemoryPool"] + "ProcessorPool", "MemoryPool", "AllocationCapabilities"] cn_names.extend(cn_names2) if curr_cim_rev >= libvirt_cim_input_graphics_ectp: cn_names.append("ConsoleRedirectionService") @@ -136,6 +138,11 @@ if profile.InstanceID not in unsupp_prof: profiles_instid_list.append(profile.InstanceID)
+ for prof_id in profiles_instid_list: + if prof_id == "CIM:DSP1041-ResourceAllocation-1.1.0c" and\ + libvirt_cim_ac_lower <= curr_cim_rev < libvirt_cim_ac_upper: + profiles_instid_list.remove(prof_id) + return status, profiles_instid_list
@do_main(sup_types)
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1236320248 28800 # Node ID b213dddc93404028075f10d7355c468ec8230274 # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7 [TEST]#4 Add "AllocationCapabilities" to associate with ECTP and skip KVM_RegisteredProfile association
Updates from 3 to 4: Use a variable to assign revision value to be calculated for comparison
Updates from 2 to 3: Add changeset instead of skip the verification of KVM_ResourceAllocation to ECTP for all the src versions
Tested for KVM/LXC with current sources and rpm on Pegasus
Signed-off-by: Guolian Yun<yunguol@cn.ibm.com>
diff -r c6f7256013b9 -r b213dddc9340 suites/libvirt-cim/cimtest/ElementConforms/01_forward.py --- a/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Tue Mar 03 08:47:40 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Thu Mar 05 22:17:28 2009 -0800 @@ -53,7 +53,9 @@ test_dom = "domU" bug_sblim = '00007' libvirt_cim_ectp_changes = 686 -libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_ac_lower = 796 +libvirt_cim_ac_upper = 818
def init_managed_ele_values(server, virt): verify_ectp_list = {} @@ -63,7 +65,7 @@ curr_cim_rev, changeset = get_provider_version(virt, server) if curr_cim_rev >= libvirt_cim_ectp_changes: cn_names2 = ["VirtualSystemMigrationService", "DiskPool", "NetworkPool", - "ProcessorPool", "MemoryPool"] + "ProcessorPool", "MemoryPool", "AllocationCapabilities"] cn_names.extend(cn_names2) if curr_cim_rev >= libvirt_cim_input_graphics_ectp: cn_names.append("ConsoleRedirectionService") @@ -136,6 +138,11 @@ if profile.InstanceID not in unsupp_prof: profiles_instid_list.append(profile.InstanceID)
+ for prof_id in profiles_instid_list: + if prof_id == "CIM:DSP1041-ResourceAllocation-1.1.0c" and\ + libvirt_cim_ac_lower <= curr_cim_rev < libvirt_cim_ac_upper:
Can you please break the libvirt_cim_ac_lower <= curr_cim_rev < libvirt_cim_ac_upper. Can you also remove the unused import statements.
+ profiles_instid_list.remove(prof_id) + return status, profiles_instid_list
@do_main(sup_types)
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik@linux.vnet.ibm.com
libvirt-cim-bounces@redhat.com wrote on 2009-03-09 14:47:41:
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1236320248 28800 # Node ID b213dddc93404028075f10d7355c468ec8230274 # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7 [TEST]#4 Add "AllocationCapabilities" to associate with ECTP and skip KVM_RegisteredProfile association
Updates from 3 to 4: Use a variable to assign revision value to be calculated for
Updates from 2 to 3: Add changeset instead of skip the verification of
KVM_ResourceAllocation to ECTP for all the src versions
Tested for KVM/LXC with current sources and rpm on Pegasus
Signed-off-by: Guolian Yun<yunguol@cn.ibm.com>
diff -r c6f7256013b9 -r b213dddc9340 suites/libvirt-
cim/cimtest/ElementConforms/01_forward.py
--- a/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Tue Mar 03 08:47:40 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Thu Mar 05 22:17:28 2009 -0800 @@ -53,7 +53,9 @@ test_dom = "domU" bug_sblim = '00007' libvirt_cim_ectp_changes = 686 -libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_ac_lower = 796 +libvirt_cim_ac_upper = 818
def init_managed_ele_values(server, virt): verify_ectp_list = {} @@ -63,7 +65,7 @@ curr_cim_rev, changeset = get_provider_version(virt, server) if curr_cim_rev >= libvirt_cim_ectp_changes: cn_names2 = ["VirtualSystemMigrationService", "DiskPool", "NetworkPool", - "ProcessorPool", "MemoryPool"] + "ProcessorPool", "MemoryPool", "AllocationCapabilities"] cn_names.extend(cn_names2) if curr_cim_rev >= libvirt_cim_input_graphics_ectp: cn_names.append("ConsoleRedirectionService") @@ -136,6 +138,11 @@ if profile.InstanceID not in unsupp_prof: profiles_instid_list.append(profile.InstanceID)
+ for prof_id in profiles_instid_list: + if prof_id == "CIM:DSP1041-ResourceAllocation-1.1.0c" and\ + libvirt_cim_ac_lower <= curr_cim_rev <
comparison libvirt_cim_ac_upper:
Can you please break the libvirt_cim_ac_lower <= curr_cim_rev < libvirt_cim_ac_upper. Can you also remove the unused import statements.
I will fix this with a new patch. Deepti - Would you please try to add all your comments in a patch review? Then I can fix all of them once a time =)
+ profiles_instid_list.remove(prof_id) + return status, profiles_instid_list
@do_main(sup_types)
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
Guo Lian Yun wrote:
libvirt-cim-bounces@redhat.com wrote on 2009-03-09 14:47:41:
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1236320248 28800 # Node ID b213dddc93404028075f10d7355c468ec8230274 # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7 [TEST]#4 Add "AllocationCapabilities" to associate with ECTP and skip KVM_RegisteredProfile association
Updates from 3 to 4: Use a variable to assign revision value to be calculated for
Updates from 2 to 3: Add changeset instead of skip the verification of
KVM_ResourceAllocation to ECTP for all the src versions
Tested for KVM/LXC with current sources and rpm on Pegasus
Signed-off-by: Guolian Yun<yunguol@cn.ibm.com>
diff -r c6f7256013b9 -r b213dddc9340 suites/libvirt-
cim/cimtest/ElementConforms/01_forward.py
--- a/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Tue Mar 03 08:47:40 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py Thu Mar 05 22:17:28 2009 -0800 @@ -53,7 +53,9 @@ test_dom = "domU" bug_sblim = '00007' libvirt_cim_ectp_changes = 686 -libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_input_graphics_ectp = 773 +libvirt_cim_ac_lower = 796 +libvirt_cim_ac_upper = 818
def init_managed_ele_values(server, virt): verify_ectp_list = {} @@ -63,7 +65,7 @@ curr_cim_rev, changeset = get_provider_version(virt, server) if curr_cim_rev >= libvirt_cim_ectp_changes: cn_names2 = ["VirtualSystemMigrationService", "DiskPool", "NetworkPool", - "ProcessorPool", "MemoryPool"] + "ProcessorPool", "MemoryPool", "AllocationCapabilities"] cn_names.extend(cn_names2) if curr_cim_rev >= libvirt_cim_input_graphics_ectp: cn_names.append("ConsoleRedirectionService") @@ -136,6 +138,11 @@ if profile.InstanceID not in unsupp_prof: profiles_instid_list.append(profile.InstanceID)
+ for prof_id in profiles_instid_list: + if prof_id == "CIM:DSP1041-ResourceAllocation-1.1.0c" and\ + libvirt_cim_ac_lower <= curr_cim_rev <
comparison libvirt_cim_ac_upper:
Can you please break the libvirt_cim_ac_lower <= curr_cim_rev < libvirt_cim_ac_upper. Can you also remove the unused import statements.
I will fix this with a new patch. Deepti - Would you please try to add all your comments in a patch review? Then I can fix all of them once a time =)
Sure. Thanks!!
+ profiles_instid_list.remove(prof_id) + return status, profiles_instid_list
@do_main(sup_types)
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
------------------------------------------------------------------------
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik@linux.vnet.ibm.com
participants (3)
-
Deepti B Kalakeri -
Guo Lian Yun -
yunguol＠cn.ibm.com