12:05 a.m.
# HG changeset patch
# User Guolian Yun <yunguol(a)cn.ibm.com>
# Date 1226297098 28800
# Node ID c85ded9735f60db2fc49475906e3611616a4a315
# Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
[TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
diff -r 6591949e8afd -r c85ded9735f6
suites/libvirt-cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
--- a/suites/libvirt-cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed Nov 05
22:03:48 2008 -0800
+++ b/suites/libvirt-cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun Nov 09
22:04:58 2008 -0800
@@ -40,9 +40,8 @@
expr_values = {
"invalid_instid_keyname" : { 'rc' : pywbem.CIM_ERR_FAILED,
'desc' : 'Missing InstanceID'},
- "invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_FAILED,
- 'desc' : 'Unable to determine\
- resource type' },
+ "invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_NOT_FOUND,
+ 'desc' : 'No such instance'},
}
def err_invalid_instid_keyname(virt, conn, field):
12:35 a.m.
This will fail for F9 rpm.
Regards,
Deepti.
yunguol(a)cn.ibm.com wrote:
# HG changeset patch
# User Guolian Yun <yunguol(a)cn.ibm.com>
# Date 1226297098 28800
# Node ID c85ded9735f60db2fc49475906e3611616a4a315
# Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
[TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
diff -r 6591949e8afd -r c85ded9735f6
suites/libvirt-cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
--- a/suites/libvirt-cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed Nov 05
22:03:48 2008 -0800
+++ b/suites/libvirt-cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun Nov 09
22:04:58 2008 -0800
@@ -40,9 +40,8 @@
expr_values = {
"invalid_instid_keyname" : { 'rc' : pywbem.CIM_ERR_FAILED,
'desc' : 'Missing InstanceID'},
- "invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_FAILED,
- 'desc' : 'Unable to determine\
- resource type' },
+ "invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_NOT_FOUND,
+ 'desc' : 'No such instance'},
}
def err_invalid_instid_keyname(virt, conn, field):
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
8:43 p.m.
New subject: [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
libvirt-cim-bounces(a)redhat.com wrote on 2008-11-10 14:35:33:
This will fail for F9 rpm.
It fails because of different error code and desc for F9 rpm and F10.
With invalid_instid_keyvalue, it expected to return {'rc' :
pywbem.CIM_ERR_FAILED, 'desc' : 'Unable to determine resource type'} for
F9,
but we expected to return {'rc' : pywbem.CIM_ERR_NOT_FOUND, 'desc' :
'No
such instance'} for F10.
I have to add a revision branch here. Would you tell me how to get the
revision number?
Thanks!
Regards,
Deepti.
yunguol(a)cn.ibm.com wrote:
> # HG changeset patch
> # User Guolian Yun <yunguol(a)cn.ibm.com>
> # Date 1226297098 28800
> # Node ID c85ded9735f60db2fc49475906e3611616a4a315
> # Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
> [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
>
> Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
>
> diff -r 6591949e8afd -r c85ded9735f6 suites/libvirt-
cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
> --- a/suites/libvirt-
cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed Nov
05 22:03:48 2008 -0800
> +++ b/suites/libvirt-
cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun Nov
09 22:04:58 2008 -0800
> @@ -40,9 +40,8 @@
> expr_values = {
> "invalid_instid_keyname" : { 'rc' : pywbem.CIM_ERR_FAILED,
> 'desc' : 'Missing InstanceID'},
> - "invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_FAILED,
> - 'desc' : 'Unable to determine\
> - resource type' },
> + "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_NOT_FOUND,
> + 'desc' : 'No such instance'},
> }
>
> def err_invalid_instid_keyname(virt, conn, field):
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
>
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
2:38 a.m.
New subject: [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
Guo Lian Yun wrote:
libvirt-cim-bounces(a)redhat.com wrote on 2008-11-10 14:35:33:
> This will fail for F9 rpm.
It fails because of different error code and desc for F9 rpm and F10.
With invalid_instid_keyvalue, it expected to return {'rc' :
pywbem.CIM_ERR_FAILED, 'desc' : 'Unable to determine resource type'}
for F9,
but we expected to return {'rc' : pywbem.CIM_ERR_NOT_FOUND, 'desc' :
'No such instance'} for F10.
I have to add a revision branch here. Would you tell me how to get
the revision number?
Yes this test need to be branched.
You can use get_provider_version() to get he revision number.
You can refer to 15_mod_system_settings.py tc for reference.
Thanks and Regards,
Deepti.
Thanks!
>
> Regards,
> Deepti.
>
> yunguol(a)cn.ibm.com wrote:
> > # HG changeset patch
> > # User Guolian Yun <yunguol(a)cn.ibm.com>
> > # Date 1226297098 28800
> > # Node ID c85ded9735f60db2fc49475906e3611616a4a315
> > # Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
> > [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
> >
> > Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
> >
> > diff -r 6591949e8afd -r c85ded9735f6 suites/libvirt-
> cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
> > --- a/suites/libvirt-
> cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed Nov
> 05 22:03:48 2008 -0800
> > +++ b/suites/libvirt-
> cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun Nov
> 09 22:04:58 2008 -0800
> > @@ -40,9 +40,8 @@
> > expr_values = {
> > "invalid_instid_keyname" : { 'rc' :
pywbem.CIM_ERR_FAILED,
> > 'desc' : 'Missing
InstanceID'},
> > - "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_FAILED,
> > - 'desc' : 'Unable to determine\
> > - resource type' },
> > + "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_NOT_FOUND,
> > + 'desc' : 'No such
instance'},
> > }
> >
> > def err_invalid_instid_keyname(virt, conn, field):
> >
> > _______________________________________________
> > Libvirt-cim mailing list
> > Libvirt-cim(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/libvirt-cim
> >
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
------------------------------------------------------------------------
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
3:33 a.m.
New subject: [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
libvirt-cim-bounces(a)redhat.com wrote on 2008-11-11 16:38:35:
Guo Lian Yun wrote:
>
> libvirt-cim-bounces(a)redhat.com wrote on 2008-11-10 14:35:33:
>
> > This will fail for F9 rpm.
>
> It fails because of different error code and desc for F9 rpm and
F10.
> With invalid_instid_keyvalue, it expected to return
{'rc' :
> pywbem.CIM_ERR_FAILED, 'desc' : 'Unable to determine resource type'}
> for F9,
> but we expected to return {'rc' : pywbem.CIM_ERR_NOT_FOUND, 'desc'
:
> 'No such instance'} for F10.
>
> I have to add a revision branch here. Would you tell me how to get
> the revision number?
Yes this test need to be branched.
You can use get_provider_version() to get he revision number.
You can refer to 15_mod_system_settings.py tc for reference.
Deepti - Thanks for your relpy.
When I try to get the changeset number for this patch, It seems that the
expect
error code number and desc are not changed yet, below is the part code
for
this case in Virt_SettingsDefineCapabilities.c with current src:
...
if (type == CIM_RES_TYPE_UNKNOWN) {
cu_statusf(_BROKER, &s,
CMPI_RC_ERR_FAILED,
"Unable to determine resource type");
goto out;
}
...
Thanks and Regards,
Deepti.
> Thanks!
>
> >
> > Regards,
> > Deepti.
> >
> > yunguol(a)cn.ibm.com wrote:
> > > # HG changeset patch
> > > # User Guolian Yun <yunguol(a)cn.ibm.com>
> > > # Date 1226297098 28800
> > > # Node ID c85ded9735f60db2fc49475906e3611616a4a315
> > > # Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
> > > [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
> > >
> > > Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
> > >
> > > diff -r 6591949e8afd -r c85ded9735f6 suites/libvirt-
> > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
> > > --- a/suites/libvirt-
> > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed Nov
> > 05 22:03:48 2008 -0800
> > > +++ b/suites/libvirt-
> > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun Nov
> > 09 22:04:58 2008 -0800
> > > @@ -40,9 +40,8 @@
> > > expr_values = {
> > > "invalid_instid_keyname" : { 'rc' :
pywbem.CIM_ERR_FAILED,
> > > 'desc' : 'Missing
InstanceID'},
> > > - "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_FAILED,
> > > - 'desc' : 'Unable to
determine\
> > > - resource type' },
> > > + "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_NOT_FOUND,
> > > + 'desc' :
'No such instance'},
> > > }
> > >
> > > def err_invalid_instid_keyname(virt, conn, field):
> > >
> > > _______________________________________________
> > > Libvirt-cim mailing list
> > > Libvirt-cim(a)redhat.com
> > > https://www.redhat.com/mailman/listinfo/libvirt-cim
> > >
> >
> > _______________________________________________
> > Libvirt-cim mailing list
> > Libvirt-cim(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/libvirt-cim
>
------------------------------------------------------------------------
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
3:49 a.m.
New subject: [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
Guo Lian Yun wrote:
libvirt-cim-bounces(a)redhat.com wrote on 2008-11-11 16:38:35:
>
>
> Guo Lian Yun wrote:
> >
> > libvirt-cim-bounces(a)redhat.com wrote on 2008-11-10 14:35:33:
> >
> > > This will fail for F9 rpm.
> >
> > It fails because of different error code and desc for F9 rpm and
F10.
> > With invalid_instid_keyvalue, it expected to return {'rc' :
> > pywbem.CIM_ERR_FAILED, 'desc' : 'Unable to determine resource
type'}
> > for F9,
> > but we expected to return {'rc' : pywbem.CIM_ERR_NOT_FOUND,
'desc' :
> > 'No such instance'} for F10.
> >
> > I have to add a revision branch here. Would you tell me how to get
> > the revision number?
> Yes this test need to be branched.
> You can use get_provider_version() to get he revision number.
> You can refer to 15_mod_system_settings.py tc for reference.
Deepti - Thanks for your relpy.
When I try to get the changeset number for this patch, It seems that
the expect
error code number and desc are not changed yet, below is the part
code for
this case in Virt_SettingsDefineCapabilities.c with current src:
...
if (type == CIM_RES_TYPE_UNKNOWN) {
cu_statusf(_BROKER, &s,
CMPI_RC_ERR_FAILED,
"Unable to determine resource type");
goto out;
}
...
Sorry I did not ask initially itself.
Which CIMOM did use when comparing the return values.
Do you use the same CIMOM on both F9 and F10 ?
> Thanks and Regards,
> Deepti.
> > Thanks!
> >
> > >
> > > Regards,
> > > Deepti.
> > >
> > > yunguol(a)cn.ibm.com wrote:
> > > > # HG changeset patch
> > > > # User Guolian Yun <yunguol(a)cn.ibm.com>
> > > > # Date 1226297098 28800
> > > > # Node ID c85ded9735f60db2fc49475906e3611616a4a315
> > > > # Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
> > > > [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
> > > >
> > > > Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
> > > >
> > > > diff -r 6591949e8afd -r c85ded9735f6 suites/libvirt-
> > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
> > > > --- a/suites/libvirt-
> > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed Nov
> > > 05 22:03:48 2008 -0800
> > > > +++ b/suites/libvirt-
> > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun Nov
> > > 09 22:04:58 2008 -0800
> > > > @@ -40,9 +40,8 @@
> > > > expr_values = {
> > > > "invalid_instid_keyname" : { 'rc' :
pywbem.CIM_ERR_FAILED,
> > > > 'desc' : 'Missing
InstanceID'},
> > > > - "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_FAILED,
> > > > - 'desc' : 'Unable to
determine\
> > > > - resource type' },
> > > > + "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_NOT_FOUND,
> > > > + 'desc' : 'No such
instance'},
> > > > }
> > > >
> > > > def err_invalid_instid_keyname(virt, conn, field):
> > > >
> > > > _______________________________________________
> > > > Libvirt-cim mailing list
> > > > Libvirt-cim(a)redhat.com
> > > > https://www.redhat.com/mailman/listinfo/libvirt-cim
> > > >
> > >
> > > _______________________________________________
> > > Libvirt-cim mailing list
> > > Libvirt-cim(a)redhat.com
> > > https://www.redhat.com/mailman/listinfo/libvirt-cim
> >
------------------------------------------------------------------------
> >
> > _______________________________________________
> > Libvirt-cim mailing list
> > Libvirt-cim(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/libvirt-cim
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
------------------------------------------------------------------------
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
4:09 a.m.
New subject: [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
Deepti B Kalakeri wrote:
Guo Lian Yun wrote:
>
> libvirt-cim-bounces(a)redhat.com wrote on 2008-11-11 16:38:35:
>
> >
> >
> > Guo Lian Yun wrote:
> > >
> > > libvirt-cim-bounces(a)redhat.com wrote on 2008-11-10 14:35:33:
> > >
> > > > This will fail for F9 rpm.
> > >
> > > It fails because of different error code and desc for F9 rpm
> and F10.
> > > With invalid_instid_keyvalue, it expected to return {'rc' :
> > > pywbem.CIM_ERR_FAILED, 'desc' : 'Unable to determine resource
type'}
> > > for F9,
> > > but we expected to return {'rc' : pywbem.CIM_ERR_NOT_FOUND,
> 'desc' :
> > > 'No such instance'} for F10.
> > >
> > > I have to add a revision branch here. Would you tell me how to get
> > > the revision number?
> > Yes this test need to be branched.
> > You can use get_provider_version() to get he revision number.
> > You can refer to 15_mod_system_settings.py tc for reference.
>
> Deepti - Thanks for your relpy.
> When I try to get the changeset number for this patch, It seems
> that the expect
> error code number and desc are not changed yet, below is the part
> code for
> this case in Virt_SettingsDefineCapabilities.c with current src:
>
> ...
> if (type == CIM_RES_TYPE_UNKNOWN) {
> cu_statusf(_BROKER, &s,
> CMPI_RC_ERR_FAILED,
> "Unable to determine resource type");
> goto out;
> }
> ...
Sorry I did not ask initially itself.
Which CIMOM did use when comparing the return values.
Do you use the same CIMOM on both F9 and F10 ?
If the problem is with different
CIMOM's returning different error
information then we dont need to use get_provider_version().
It would be good idea to verify what CIMOM is there on the machine and
check the error information accordingly instead of modifying and
verifying the common information in the error description for pegasus
and sfcb.This will be good in case where two error messages occurring
because of different reasons are partly same, and hence avoid false
positives.
Any thoughts??
Thanks and Regards,
Deepti.
>
> > Thanks and Regards,
> > Deepti.
> > > Thanks!
> > >
> > > >
> > > > Regards,
> > > > Deepti.
> > > >
> > > > yunguol(a)cn.ibm.com wrote:
> > > > > # HG changeset patch
> > > > > # User Guolian Yun <yunguol(a)cn.ibm.com>
> > > > > # Date 1226297098 28800
> > > > > # Node ID c85ded9735f60db2fc49475906e3611616a4a315
> > > > > # Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
> > > > > [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
> > > > >
> > > > > Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
> > > > >
> > > > > diff -r 6591949e8afd -r c85ded9735f6 suites/libvirt-
> > > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
> > > > > --- a/suites/libvirt-
> > > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed
> Nov
> > > > 05 22:03:48 2008 -0800
> > > > > +++ b/suites/libvirt-
> > > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun
> Nov
> > > > 09 22:04:58 2008 -0800
> > > > > @@ -40,9 +40,8 @@
> > > > > expr_values = {
> > > > > "invalid_instid_keyname" : { 'rc' :
> pywbem.CIM_ERR_FAILED,
> > > > > 'desc' : 'Missing
> InstanceID'},
> > > > > - "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_FAILED,
> > > > > - 'desc' : 'Unable to
determine\
> > > > > - resource type' },
> > > > > + "invalid_instid_keyvalue" : { 'rc' :
> pywbem.CIM_ERR_NOT_FOUND,
> > > > > + 'desc' : 'No such
instance'},
> > > > > }
> > > > >
> > > > > def err_invalid_instid_keyname(virt, conn, field):
> > > > >
> > > > > _______________________________________________
> > > > > Libvirt-cim mailing list
> > > > > Libvirt-cim(a)redhat.com
> > > > > https://www.redhat.com/mailman/listinfo/libvirt-cim
> > > > > > > >
> > > > _______________________________________________
> > > > Libvirt-cim mailing list
> > > > Libvirt-cim(a)redhat.com
> > > > https://www.redhat.com/mailman/listinfo/libvirt-cim
> > >
> ------------------------------------------------------------------------
> > >
> > > _______________________________________________
> > > Libvirt-cim mailing list
> > > Libvirt-cim(a)redhat.com
> > > https://www.redhat.com/mailman/listinfo/libvirt-cim
> >
> > _______________________________________________
> > Libvirt-cim mailing list
> > Libvirt-cim(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/libvirt-cim
> ------------------------------------------------------------------------
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
8:27 p.m.
New subject: [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
libvirt-cim-bounces(a)redhat.com wrote on 2008-11-11 18:09:52:
Deepti B Kalakeri wrote:
>
>
> Guo Lian Yun wrote:
>>
>> libvirt-cim-bounces(a)redhat.com wrote on 2008-11-11 16:38:35:
>>
>> >
>> >
>> > Guo Lian Yun wrote:
>> > >
>> > > libvirt-cim-bounces(a)redhat.com wrote on 2008-11-10 14:35:33:
>> > >
>> > > > This will fail for F9 rpm.
>> > >
>> > > It fails because of different error code and desc for F9 rpm
>> and F10.
>> > > With invalid_instid_keyvalue, it expected to return {'rc' :
>> > > pywbem.CIM_ERR_FAILED, 'desc' : 'Unable to determine
resource
type'}
>> > > for F9,
>> > > but we expected to return {'rc' : pywbem.CIM_ERR_NOT_FOUND,
>> 'desc' :
>> > > 'No such instance'} for F10.
>> > >
>> > > I have to add a revision branch here. Would you tell me how to
get
>> > > the revision number?
>> > Yes this test need to be branched.
>> > You can use get_provider_version() to get he revision number.
>> > You can refer to 15_mod_system_settings.py tc for reference.
>>
>> Deepti - Thanks for your relpy.
>> When I try to get the changeset number for this patch, It seems
>> that the expect
>> error code number and desc are not changed yet, below is the part
>> code for
>> this case in Virt_SettingsDefineCapabilities.c with current src:
>>
>> ...
>> if (type == CIM_RES_TYPE_UNKNOWN) {
>> cu_statusf(_BROKER, &s,
>> CMPI_RC_ERR_FAILED,
>> "Unable to determine resource type");
>> goto out;
>> }
>> ...
> Sorry I did not ask initially itself.
> Which CIMOM did use when comparing the return values.
> Do you use the same CIMOM on both F9 and F10 ?
If the problem is with different CIMOM's returning different error
information then we dont need to use get_provider_version().
It would be good idea to verify what CIMOM is there on the machine and
check the error information accordingly instead of modifying and
verifying the common information in the error description for pegasus
and sfcb.This will be good in case where two error messages occurring
because of different reasons are partly same, and hence avoid false
positives.
This tc return both different error code and descriptions for sfcb and
pegasus.
It seems that somebody says it isn't a good idea to check the cimom type
in tc.
I'm not sure if we can deal with this by other ways.
Thanks!
Any thoughts??
Thanks and Regards,
Deepti.
>>
>> > Thanks and Regards,
>> > Deepti.
>> > > Thanks!
>> > >
>> > > >
>> > > > Regards,
>> > > > Deepti.
>> > > >
>> > > > yunguol(a)cn.ibm.com wrote:
>> > > > > # HG changeset patch
>> > > > > # User Guolian Yun <yunguol(a)cn.ibm.com>
>> > > > > # Date 1226297098 28800
>> > > > > # Node ID c85ded9735f60db2fc49475906e3611616a4a315
>> > > > > # Parent 6591949e8afdddce6aa72022e33f0ce063ec60a1
>> > > > > [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
>> > > > >
>> > > > > Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com>
>> > > > >
>> > > > > diff -r 6591949e8afd -r c85ded9735f6 suites/libvirt-
>> > > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py
>> > > > > --- a/suites/libvirt-
>> > > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Wed
>> Nov
>> > > > 05 22:03:48 2008 -0800
>> > > > > +++ b/suites/libvirt-
>> > > > cim/cimtest/SettingsDefineCapabilities/03_forward_errs.py Sun
>> Nov
>> > > > 09 22:04:58 2008 -0800
>> > > > > @@ -40,9 +40,8 @@
>> > > > > expr_values = {
>> > > > > "invalid_instid_keyname" : { 'rc' :
>> pywbem.CIM_ERR_FAILED,
>> > > > > 'desc' :
'Missing
>> InstanceID'},
>> > > > > - "invalid_instid_keyvalue" : { 'rc' :
pywbem.CIM_ERR_FAILED,
>> > > > > -
'desc' : 'Unable to
determine\
>> > > > > - resource type' },
>> > > > > + "invalid_instid_keyvalue" : { 'rc' :
>> pywbem.CIM_ERR_NOT_FOUND,
>> > > > > + 'desc' : 'No
such
instance'},
>> > > > > }
>> > > > >
>> > > > > def err_invalid_instid_keyname(virt, conn, field):
>> > > > >
>> > > > > _______________________________________________
>> > > > > Libvirt-cim mailing list
>> > > > > Libvirt-cim(a)redhat.com
>> > > > > https://www.redhat.com/mailman/listinfo/libvirt-cim
>> > > > > > > >
>> > > > _______________________________________________
>> > > > Libvirt-cim mailing list
>> > > > Libvirt-cim(a)redhat.com
>> > > > https://www.redhat.com/mailman/listinfo/libvirt-cim
>> > >
>>
------------------------------------------------------------------------
>> > >
>> > > _______________________________________________
>> > > Libvirt-cim mailing list
>> > > Libvirt-cim(a)redhat.com
>> > > https://www.redhat.com/mailman/listinfo/libvirt-cim
>> >
>> > _______________________________________________
>> > Libvirt-cim mailing list
>> > Libvirt-cim(a)redhat.com
>> > https://www.redhat.com/mailman/listinfo/libvirt-cim
>>
------------------------------------------------------------------------
>>
>> _______________________________________________
>> Libvirt-cim mailing list
>> Libvirt-cim(a)redhat.com
>> https://www.redhat.com/mailman/listinfo/libvirt-cim
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
5:44 p.m.
New subject: [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
> >> > > It fails because of different error code
and desc for F9 rpm
> >> and F10.
> >> > > With invalid_instid_keyvalue, it expected to return
{'rc' :
> >> > > pywbem.CIM_ERR_FAILED, 'desc' : 'Unable to determine
resource
type'}
> >> > > for F9,
> >> > > but we expected to return {'rc' :
pywbem.CIM_ERR_NOT_FOUND,
> >> 'desc' :
> >> > > 'No such instance'} for F10.
> >> > >
> >> > > I have to add a revision branch here. Would you tell me how
to get
> >> > > the revision number?
> >> > Yes this test need to be branched.
> >> > You can use get_provider_version() to get he revision number.
> >> > You can refer to 15_mod_system_settings.py tc for reference.
> >>
> >> Deepti - Thanks for your relpy.
> >> When I try to get the changeset number for this patch, It seems
> >> that the expect
> >> error code number and desc are not changed yet, below is the part
> >> code for
> >> this case in Virt_SettingsDefineCapabilities.c with current src:
> >>
> >> ...
> >> if (type == CIM_RES_TYPE_UNKNOWN) {
> >> cu_statusf(_BROKER, &s,
> >> CMPI_RC_ERR_FAILED,
> >> "Unable to determine resource
type");
> >> goto out;
> >> }
> >> ...
> > Sorry I did not ask initially itself.
> > Which CIMOM did use when comparing the return values.
> > Do you use the same CIMOM on both F9 and F10 ?
> If the problem is with different CIMOM's returning different error
> information then we dont need to use get_provider_version().
> It would be good idea to verify what CIMOM is there on the machine and
> check the error information accordingly instead of modifying and
> verifying the common information in the error description for pegasus
> and sfcb.This will be good in case where two error messages occurring
> because of different reasons are partly same, and hence avoid false
> positives.
This tc return both different error code and descriptions for sfcb and
pegasus.
It seems that somebody says it isn't a good idea to check the cimom
type in tc.
I'm not sure if we can deal with this by other ways.
Thanks!
Daisy - did you resolve your problem? I tested with an F9 rpm using
Pegasus, and this test passed for me.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com
7:49 p.m.
New subject: [Libvirt-cim] [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
libvirt-cim-bounces(a)redhat.com wrote on 2008-11-13 07:44:12:
> > >> > > It fails because of different error
code and desc for F9
rpm
> > >> and F10.
> > >> > > With invalid_instid_keyvalue, it expected to return
{'rc'
:
> > >> > > pywbem.CIM_ERR_FAILED, 'desc' :
'Unable to determine
resource
> type'}
> > >> > > for F9,
> > >> > > but we expected to return {'rc' :
pywbem.CIM_ERR_NOT_FOUND,
> > >> 'desc' :
> > >> > > 'No such instance'} for F10.
> > >> > >
> > >> > > I have to add a revision branch here. Would you tell me
how
> to get
> > >> > > the revision number?
> > >> > Yes this test need to be branched.
> > >> > You can use get_provider_version() to get he revision number.
> > >> > You can refer to 15_mod_system_settings.py tc for reference.
> > >>
> > >> Deepti - Thanks for your relpy.
> > >> When I try to get the changeset number for this patch, It
seems
> > >> that the expect
> > >> error code number and desc are not changed yet, below is the
part
> > >> code for
> > >> this case in Virt_SettingsDefineCapabilities.c with current
src:
> > >>
> > >> ...
> > >> if (type == CIM_RES_TYPE_UNKNOWN) {
> > >> cu_statusf(_BROKER, &s,
> > >> CMPI_RC_ERR_FAILED,
> > >> "Unable to determine resource
type");
> > >> goto out;
> > >> }
> > >> ...
> > > Sorry I did not ask initially itself.
> > > Which CIMOM did use when comparing the return values.
> > > Do you use the same CIMOM on both F9 and F10 ?
> > If the problem is with different CIMOM's returning different error
> > information then we dont need to use get_provider_version().
> > It would be good idea to verify what CIMOM is there on the machine
and
> > check the error information accordingly instead of
modifying and
> > verifying the common information in the error description for
pegasus
> > and sfcb.This will be good in case where two error
messages
occurring
> > because of different reasons are partly same, and hence
avoid false
> > positives.
>
> This tc return both different error code and descriptions for sfcb
and
> pegasus.
> It seems that somebody says it isn't a good idea to check the cimom
> type in tc.
> I'm not sure if we can deal with this by other ways.
> Thanks!
Daisy - did you resolve your problem? I tested with an F9 rpm using
Pegasus, and this test passed for me.
This tc passes for Pegasus, but it fails for sfcb.
It expects different error code and description for sfcb and Pegasus.
If I change the expr_valuese from 1) to 2), it passes for sfcb.
1)
expr_values = {
"invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_FAILED,
'desc' : 'Unable to determine\
resource type' },
}
2)
expr_values = {
"invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_NOT_FOUNG,
'desc' : 'No such instance' },
}
Maybe we can verify what CIMOM is there on the machine and check the
error information accordingly to fix this issue,
but I remember that somebody says it isn't a good idea to check the cimom
type in tc, any better idea?
Thanks!
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
5:57 p.m.
New subject: [Libvirt-cim] [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
> Daisy - did you resolve your problem? I tested with an F9 rpm
using
> Pegasus, and this test passed for me.
>
>
This tc passes for Pegasus, but it fails for sfcb.
It expects different error code and description for sfcb and Pegasus.
If I change the expr_valuese from 1) to 2), it passes for sfcb.
1)
expr_values = {
"invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_FAILED,
'desc' : 'Unable to determine\
resource type' },
}
2)
expr_values = {
"invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_NOT_FOUNG,
'desc' : 'No such instance' },
}
Maybe we can verify what CIMOM is there on the machine and check the
error information accordingly to fix this issue,
but I remember that somebody says it isn't a good idea to check the
cimom type in tc, any better idea?
Thanks!
This isn't a difference in CIMOMs. If you run with recent providers
with both sfcb and pegasus, the test will fail on systems.
This failure is due to a change in the providers - it's due to changeset
721. So you'll need to branch this test case so that the error messages
are appropriate for the given provider revision.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com
11:31 p.m.
New subject: [Libvirt-cim] [PATCH] [TEST] Fix SettingsDefineCapabilities/03_forward_errs.py
libvirt-cim-bounces(a)redhat.com wrote on 2008-11-14 07:57:14:
> > Daisy - did you resolve your problem? I tested with an F9
rpm
using
> > Pegasus, and this test passed for me.
> >
> >
> This tc passes for Pegasus, but it fails for sfcb.
> It expects different error code and description for sfcb and
Pegasus.
>
> If I change the expr_valuese from 1) to 2), it passes for sfcb.
>
> 1)
> expr_values = {
> "invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_FAILED,
> 'desc' : 'Unable to determine\
> resource type' },
> }
>
> 2)
> expr_values = {
> "invalid_instid_keyvalue" : { 'rc' : pywbem.CIM_ERR_NOT_FOUNG,
> 'desc' : 'No such instance' },
> }
>
> Maybe we can verify what CIMOM is there on the machine and check the
> error information accordingly to fix this issue,
> but I remember that somebody says it isn't a good idea to check the
> cimom type in tc, any better idea?
>
> Thanks!
This isn't a difference in CIMOMs. If you run with recent providers
with both sfcb and pegasus, the test will fail on systems.
This failure is due to a change in the providers - it's due to changeset
721. So you'll need to branch this test case so that the error
messages
are appropriate for the given provider revision.
Thanks - Kaitlin.
I'll cook up a patch for this.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com
_______________________________________________
Libvirt-cim mailing list
Libvirt-cim(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvirt-cim
5882
days inactive
5886
days old
11 comments
4 participants
participants (4)
-
Deepti B Kalakeri -
Guo Lian Yun -
Kaitlin Rupert -
yunguol＠cn.ibm.com