[PATCH] libvirt-cim.spec.in: Uninstall open-pegasus-specific providers

Older libvirt-cim might've installed these in the sblim-sfcb repository, causing errors when calling sfcbrepos on libvirt-cim update. --- libvirt-cim.spec.in | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libvirt-cim.spec.in b/libvirt-cim.spec.in index a027246..cd399b1 100644 --- a/libvirt-cim.spec.in +++ b/libvirt-cim.spec.in @@ -84,6 +84,13 @@ rm -fr $RPM_BUILD_ROOT -n @CIM_VIRT_NS@ \ -r %{REGISTRATION} -m %{SCHEMA} >/dev/null 2>&1 || true +# Remove open-pegasus-specific providers installed in sfcb repository +# by older libvirt-cim packages +%{_datadir}/%{name}/provider-register.sh -d -t sfcb \ + -n root/PG_InterOp \ + -r %{PGINTEROP_REG} -m %{PGINTEROP_MOF} >/dev/null 2>&1 || true + + %post /sbin/ldconfig -- 1.8.1.5

On 08/21/2013 10:19 AM, Ján Tomko wrote:
+# Remove open-pegasus-specific providers installed in sfcb repository +# by older libvirt-cim packages +%{_datadir}/%{name}/provider-register.sh -d -t sfcb \ + -n root/PG_InterOp \ + -r %{PGINTEROP_REG} -m %{PGINTEROP_MOF} >/dev/null 2>&1 || true + +
I'm no expert in this matter, but I wonder if those would ever have been installed. Does anyone have a RHEL6 environment with sfcb only where pginterop was installed? I guess I see no harm in this, but I have less experience with the sfcb environment... Anyone else have comments/thoughts? John

----- Original Message -----
I'm no expert in this matter, but I wonder if those would ever have been installed. Does anyone have a RHEL6 environment with sfcb only where pginterop was installed?
I have RHEL6.5 with sfcb installed.
I guess I see no harm in this, but I have less experience with the sfcb environment... Anyone else have comments/thoughts?
I remember I have verified a bug https://bugzilla.redhat.com/show_bug.cgi?id=859122
John
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim

On 08/22/2013 04:10 AM, Jincheng Miao wrote:
----- Original Message -----
I'm no expert in this matter, but I wonder if those would ever have been installed. Does anyone have a RHEL6 environment with sfcb only where pginterop was installed?
I have RHEL6.5 with sfcb installed.
Which hasn't been released yet.
I guess I see no harm in this, but I have less experience with the sfcb environment... Anyone else have comments/thoughts?
I remember I have verified a bug https://bugzilla.redhat.com/show_bug.cgi?id=859122
I prefer not to post private bugzilla links to public lists, as they result in a rather annoying big red "access denied" message to most of the people. Jan

On 08/22/2013 02:14 AM, John Ferlan wrote:
On 08/21/2013 10:19 AM, Ján Tomko wrote:
+# Remove open-pegasus-specific providers installed in sfcb repository +# by older libvirt-cim packages +%{_datadir}/%{name}/provider-register.sh -d -t sfcb \ + -n root/PG_InterOp \ + -r %{PGINTEROP_REG} -m %{PGINTEROP_MOF} >/dev/null 2>&1 || true + +
I'm no expert in this matter, but I wonder if those would ever have been installed. Does anyone have a RHEL6 environment with sfcb only where pginterop was installed?
Yes, if you install libvirt-cim-0.6.1-4.el6 (which is the version in RHEL6.4), PG_InterOp would get installed as well. Since upstream commit 07adabc, the providers registered on installation are only unregistered on uninstall, not update. Commit 19ffef8 only fixed this for uninstall -> install, where PG_InterOp gets unregistered by the old package (without this commit) and the new package (with the commit) doesn't register it. On upgrade, the old package leaves it behind. Jan

----- Original Message -----
Yes, if you install libvirt-cim-0.6.1-4.el6 (which is the version in RHEL6.4), PG_InterOp would get installed as well.
Since upstream commit 07adabc, the providers registered on installation are only unregistered on uninstall, not update.
Commit 19ffef8 only fixed this for uninstall -> install, where PG_InterOp gets unregistered by the old package (without this commit) and the new package (with the commit) doesn't register it.
On upgrade, the old package leaves it behind.
yes, confirm. some verification steps: 1. for old package it can clean the PG_InterOp as we seen # rpm -ivh libvirt-cim-0.6.1-4.el6_4.1.x86_64.rpm Preparing... ########################################### [100%] 1:libvirt-cim ########################################### [100%] [ OK ] down CIM server: [ OK ] Starting up CIM server: [ OK ] # ls /var/lib/sfcb/registration/repository/root/ cimv2 interop PG_InterOp virt # rpm -e libvirt-cim Deleting registered classes in libvirt-cim. Deleting registered classes in libvirt-cim. # ls /var/lib/sfcb/registration/repository/root/ cimv2 interop 2. for upgrade libvirt-cim # rpm -ivh libvirt-cim-0.6.1-4.el6_4.1.x86_64.rpm Preparing... ########################################### [100%] 1:libvirt-cim ########################################### [100%] [ OK ] down CIM server: [ OK ] Starting up CIM server: [ OK ] # ls /var/lib/sfcb/registration/repository/root/ cimv2 interop PG_InterOp virt # sfcbrepos -f -c /usr/share/mof/cimv2.22.0/ logger not started*** Repository error for /var/lib/sfcb/registration/repository//root/pg_interop/qualifiers could not write qualifier Association backend error has occured writing classSchemas Failed compiling the MOF files. # rpm -Uvh libvirt-cim-0.6.1-7.el6.x86_64.rpm Preparing... ########################################### [100%] 1:libvirt-cim ########################################### [100%] [ OK ] down CIM server: [ OK ] Starting up CIM server: [ OK ] # ls /var/lib/sfcb/registration/repository/root/ cimv2 interop PG_InterOp virt # sfcbrepos -f -c /usr/share/mof/cimv2.22.0/ logger not started*** Repository error for /var/lib/sfcb/registration/repository//root/pg_interop/qualifiers could not write qualifier Association backend error has occured writing classSchemas Failed compiling the MOF files. # rpm -e libvirt-cim Deleting registered classes in libvirt-cim. Deleting registered classes in libvirt-cim. # ls /var/lib/sfcb/registration/repository/root/ cimv2 interop PG_InterOp Here we can still find PG_InterOp. So we should keep the clean script for PG_InterOp.

On 08/22/2013 01:02 PM, John Ferlan wrote:
On 08/21/2013 10:19 AM, Ján Tomko wrote:
Older libvirt-cim might've installed these in the sblim-sfcb repository, causing errors when calling sfcbrepos on libvirt-cim update. --- libvirt-cim.spec.in | 7 +++++++ 1 file changed, 7 insertions(+)
ACK
John
Thank you, pushed now. Jan
participants (3)
-
Jincheng Miao
-
John Ferlan
-
Ján Tomko