[PATCH] Fix typos for disk & network classes in SDC SD & EAFP
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1196763876 -28800 # Node ID 7dbad83883a3f5eaeedac4e415a97fb459ec50e5 # Parent 7fd4f296b8cc328a7492a24c731d8722bc485452 Fix typos for disk & network classes in SDC SD & EAFP *_LogicalDisk & *_NetworkPort classes are typo-ed as *_Disk & *_Network in several assoc classes' handler param. This leads to some assoc failure. Signed-off-by: Zhengang Li <lizg@cn.ibm.com> diff -r 7fd4f296b8cc -r 7dbad83883a3 src/Virt_ElementAllocatedFromPool.c --- a/src/Virt_ElementAllocatedFromPool.c Mon Dec 03 13:35:16 2007 +0100 +++ b/src/Virt_ElementAllocatedFromPool.c Tue Dec 04 18:24:36 2007 +0800 @@ -279,12 +279,12 @@ char* dependent[] = { char* dependent[] = { "Xen_Processor", "Xen_Memory", - "Xen_Network", - "Xen_Disk", + "Xen_NetworkPort", + "Xen_LogicalDisk", "KVM_Processor", "KVM_Memory", - "KVM_Network", - "KVM_Disk", + "KVM_NetworkPort", + "KVM_LogicalDisk", NULL }; diff -r 7fd4f296b8cc -r 7dbad83883a3 src/Virt_SettingsDefineState.c --- a/src/Virt_SettingsDefineState.c Mon Dec 03 13:35:16 2007 +0100 +++ b/src/Virt_SettingsDefineState.c Tue Dec 04 18:24:36 2007 +0800 @@ -304,12 +304,12 @@ char* logical_device[] = { char* logical_device[] = { "Xen_Processor", "Xen_Memory", - "Xen_Network", - "Xen_Disk", + "Xen_NetworkPort", + "Xen_LogicalDisk", "KVM_Processor", "KVM_Memory", - "KVM_Network", - "KVM_Disk", + "KVM_NetworkPort", + "KVM_LogicalDisk", NULL }; diff -r 7fd4f296b8cc -r 7dbad83883a3 src/Virt_SystemDevice.c --- a/src/Virt_SystemDevice.c Mon Dec 03 13:35:16 2007 +0100 +++ b/src/Virt_SystemDevice.c Tue Dec 04 18:24:36 2007 +0800 @@ -241,12 +241,12 @@ char* part_component[] = { char* part_component[] = { "Xen_Processor", "Xen_Memory", - "Xen_Network", - "Xen_Disk", + "Xen_NetworkPort", + "Xen_LogicalDisk", "KVM_Processor", "KVM_Memory", - "KVM_Network", - "KVM_Disk", + "KVM_NetworkPort", + "KVM_LogicalDisk", NULL };
lizg@cn.ibm.com wrote:
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1196763876 -28800 # Node ID 7dbad83883a3f5eaeedac4e415a97fb459ec50e5 # Parent 7fd4f296b8cc328a7492a24c731d8722bc485452 Fix typos for disk & network classes in SDC SD & EAFP
*_LogicalDisk & *_NetworkPort classes are typo-ed as *_Disk & *_Network in several assoc classes' handler param. This leads to some assoc failure. This is "No handler found" failure I saw on cimom's log. The fix should bring back some of the test cases failure. :)
Signed-off-by: Zhengang Li <lizg@cn.ibm.com>
diff -r 7fd4f296b8cc -r 7dbad83883a3 src/Virt_ElementAllocatedFromPool.c --- a/src/Virt_ElementAllocatedFromPool.c Mon Dec 03 13:35:16 2007 +0100 +++ b/src/Virt_ElementAllocatedFromPool.c Tue Dec 04 18:24:36 2007 +0800 @@ -279,12 +279,12 @@ char* dependent[] = { char* dependent[] = { "Xen_Processor", "Xen_Memory", - "Xen_Network", - "Xen_Disk", + "Xen_NetworkPort", + "Xen_LogicalDisk", "KVM_Processor", "KVM_Memory", - "KVM_Network", - "KVM_Disk", + "KVM_NetworkPort", + "KVM_LogicalDisk", NULL };
diff -r 7fd4f296b8cc -r 7dbad83883a3 src/Virt_SettingsDefineState.c --- a/src/Virt_SettingsDefineState.c Mon Dec 03 13:35:16 2007 +0100 +++ b/src/Virt_SettingsDefineState.c Tue Dec 04 18:24:36 2007 +0800 @@ -304,12 +304,12 @@ char* logical_device[] = { char* logical_device[] = { "Xen_Processor", "Xen_Memory", - "Xen_Network", - "Xen_Disk", + "Xen_NetworkPort", + "Xen_LogicalDisk", "KVM_Processor", "KVM_Memory", - "KVM_Network", - "KVM_Disk", + "KVM_NetworkPort", + "KVM_LogicalDisk", NULL };
diff -r 7fd4f296b8cc -r 7dbad83883a3 src/Virt_SystemDevice.c --- a/src/Virt_SystemDevice.c Mon Dec 03 13:35:16 2007 +0100 +++ b/src/Virt_SystemDevice.c Tue Dec 04 18:24:36 2007 +0800 @@ -241,12 +241,12 @@ char* part_component[] = { char* part_component[] = { "Xen_Processor", "Xen_Memory", - "Xen_Network", - "Xen_Disk", + "Xen_NetworkPort", + "Xen_LogicalDisk", "KVM_Processor", "KVM_Memory", - "KVM_Network", - "KVM_Disk", + "KVM_NetworkPort", + "KVM_LogicalDisk", NULL };
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- - Zhengang
lizg@cn.ibm.com wrote:
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1196763876 -28800 # Node ID 7dbad83883a3f5eaeedac4e415a97fb459ec50e5 # Parent 7fd4f296b8cc328a7492a24c731d8722bc485452 Fix typos for disk & network classes in SDC SD & EAFP
*_LogicalDisk & *_NetworkPort classes are typo-ed as *_Disk & *_Network in several assoc classes' handler param. This leads to some assoc failure.
Signed-off-by: Zhengang Li <lizg@cn.ibm.com>
Excellent catch! +1 -- Kaitlin Rupert IBM Linux Technology Center karupert@us.ibm.com
ZL> # HG changeset patch ZL> # User Zhengang Li <lizg@cn.ibm.com> ZL> # Date 1196763876 -28800 ZL> # Node ID 7dbad83883a3f5eaeedac4e415a97fb459ec50e5 ZL> # Parent 7fd4f296b8cc328a7492a24c731d8722bc485452 ZL> Fix typos for disk & network classes in SDC SD & EAFP Excellent catch. I think this was just changed recently. I should have spotted those errors before I committed the change. Thanks a lot! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com
lizg@cn.ibm.com wrote:
# HG changeset patch # User Zhengang Li <lizg@cn.ibm.com> # Date 1196763876 -28800 # Node ID 7dbad83883a3f5eaeedac4e415a97fb459ec50e5 # Parent 7fd4f296b8cc328a7492a24c731d8722bc485452 Fix typos for disk & network classes in SDC SD & EAFP
*_LogicalDisk & *_NetworkPort classes are typo-ed as *_Disk & *_Network in several assoc classes' handler param. This leads to some assoc failure.
Signed-off-by: Zhengang Li <lizg@cn.ibm.com>
Great catch :) ... sorry, this was my inattention. -- Regards Heidi Eckhart Software Engineer Linux Technology Center - Open Hypervisor heidieck@linux.vnet.ibm.com ************************************************** IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschaeftsfuehrung: Herbert Kircher Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
participants (5)
-
Dan Smith -
Heidi Eckhart -
Kaitlin Rupert -
lizg＠cn.ibm.com -
Zhengang Li