Re: [Libvirt-cim] [PATCH] Fix include of internal headers

Kaitlin Rupert wrote: > Dan Smith wrote: > >> # HG changeset patch >> # User Dan Smith <danms(a)us.ibm.com&gt; >> # Date 1200498221 28800 >> # Node ID fd28a485f90399d166eb62816c32e2d7727cced6 >> # Parent ef0dd32ef7faf101f97acfa0f0268bf18c22dcac >> Fix include of internal headers >> >> This was causing me problems when installing libcmpiutil into /usr/local >> for testing. I think this is the right solution, and seems to work >> for me >> in both cases. >> >> Signed-off-by: Dan Smith <danms(a)us.ibm.com&gt; >> >> diff -r ef0dd32ef7fa -r fd28a485f903 std_indication.h >> --- a/std_indication.h Wed Jan 16 06:33:30 2008 -0800 >> +++ b/std_indication.h Wed Jan 16 07:43:41 2008 -0800 >> @@ -25,8 +25,8 @@ >> #include <cmpift.h> >> #include <cmpimacs.h> >> >> -#include <libcmpiutil.h> >> -#include <std_invokemethod.h> >> +#include "libcmpiutil.h" >> +#include "std_invokemethod.h" >> >> CMPIStatus stdi_trigger_indication(const CMPIBroker *broker, >> const CMPIContext *context, >> > Agreed. I think a project shouldn't need to use <> for its own header > files (in most cases anyway). +1 > > Yea, I'm on board with that.