[Libvirt-cim] [PATCH] Remove extra cu_statusf() call from VSMigrationService.c

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com&gt; # Date 1209426269 25200 # Node ID 92702225dbafa13d2f7201b3fe5baeaebd07100d # Parent a9f38d1726784a85db09602c53ad990819047690 Remove extra cu_statusf() call from VSMigrationService.c Unfortunately, the patch doesn't include the appropriate context (see below). The issue here is that the if/else blocks call cu_statusf() to set the status. There's no goto in the else block, so this extra cu_statusf() is called - even when we've encountered an error. if (remote >= local) { /* Success */ } else { /* Failure */ } Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com&gt; diff -r a9f38d172678 -r 92702225dbaf src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Fri Apr 25 16:10:31 2008 -0700 +++ b/src/Virt_VSMigrationService.c Mon Apr 28 16:44:29 2008 -0700 @@ -267,9 +267,6 @@ static CMPIStatus check_hver(virConnectP remote, local); } - cu_statusf(_BROKER, &s, - CMPI_RC_OK, - ""); out: return s; }