Re: [Libvirt-cim] [PATCH]
Jay Gagnon wrote:
Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert(a)us.ibm.com>
> # Date 1197410852 28800
> # Node ID 8761c7b39ea87feb54f89e41e1a7044104ec9399
> # Parent 6c3ca59055416d7bb07716d3a750800e6087878e
> #2 GetInstance() does not return an instance that matches the instanceID given.
>
Good patch and all, but it looks like something about your commit
message is making it treat the "#2 GetInstance()..." as a comment, hence
the blank subject line.
Ah. I just looked back at our other "#foo" patches, and it looks like
they have all been patchsets or [RFC] type patches, so no actual patch
(until this one) has had its commit message start with the pound sign.
I guess we'll have to revise the guidelines a little. Any suggestions?
I was confused too when I saw the mail send without a subject. =) Dan
suggested including a space before the pound sign. I'm not sure if that
will work, but I can try next time I have to resubmit a patch.
--
Kaitlin Rupert
IBM Linux Technology Center
karupert(a)us.ibm.com