Re: [Libvirt-cim] [PATCH 0 of 3] #3 - Enhance std association logic for reference lists and input parameter handling
Heidi Eckhart wrote:
Please don't ask me what happened to the patch set before and why
patch 3 was not submitted to the list. So resending the complete patch set once again ...
and hope.
This patch set fixes:
- enhance the std_assoc struct to support lists for source, target and association
classnames
- fixed a wrong error return for a NULL handler
- reworked check for input parameter: assocClass, resultClass, role, resultRole
The set looks good. I liked the added role, resultRole support. Also,
I liked how you moved the checking of assocClass, resultClass, role,
resultRole to std_assoc_get_handler() instead of do_assoc(). It seems
like a more applicable place since std_assoc_get_handler() is supposed
to determine whether the provider can handle the association, and if so,
which function will be handling the call. Nice work =) +1
One odd thing I noticed about this patch set is that I could only get
the ECTP association to build properly. It seems like the other
associations need to be updated like ECTP before they will build
properly. This is strange because I was able to build all of the
associations with the first iteration of the patchset without problems.
I didn't see anything obvious that would cause the change. It looks
like all the providers will need to be updated at the same time the
libcmpiutil pieces are checked in, which probably makes sense anyway. =)
--
Kaitlin Rupert
IBM Linux Technology Center
karupert(a)us.ibm.com