Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1204836739 28800 # Node ID eb68bdbdf6ea6b596ceefd72a5547dfa65b27225 # Parent 1e01f52781b5499949f498553b453f23af8feec2 Extend the VirtualSystemMigrationSettingData to include an attribute for transport method.
Possible transport methods are those supported by libvirt: ssh, tls, unix sockets, and tcp.
Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com>
diff -r 1e01f52781b5 -r eb68bdbdf6ea schema/VSMigrationSettingData.mof --- a/schema/VSMigrationSettingData.mof Thu Mar 06 12:53:44 2008 -0800 +++ b/schema/VSMigrationSettingData.mof Thu Mar 06 12:52:19 2008 -0800 @@ -8,8 +8,34 @@ class CIM_VirtualSystemMigrationSettingD
[Provider("cmpi::Virt_VSMigrationSettingData")] class Xen_VirtualSystemMigrationSettingData : CIM_VirtualSystemMigrationSettingData { + [ Description( + "TransportType describes a type of transport used during the migration " + "operation.\n" + "A value of 2 - Virtual System is to be migrated using SSH.\n" + "A value of 3 - Virtual System is to be migrated using TLS.\n" + "A value of 4 - Virtual System is to be migrated using TLS with strict" + "verifcation of the remote certificates.\n" + "A value of 5 - Virtual System is to be migrated using TCP.\n" + "A value of 6 - Virtual System is to be migrated using UNIX sockets" + "(localhost only).\n"), + ValueMap {"0","1","2","3","4","5","6"}, + Values { "Unknown", "Other", "SSH", "TLS", "TLS Strict", "TCP", "UNIX" }] + uint16 TransportType; };
[Provider("cmpi::Virt_VSMigrationSettingData")] class KVM_VirtualSystemMigrationSettingData : CIM_VirtualSystemMigrationSettingData { + [ Description( + "TransportType describes a type of transport used during the migration " + "operation.\n" + "A value of 2 - Virtual System is to be migrated using SSH.\n" + "A value of 3 - Virtual System is to be migrated using TLS.\n" + "A value of 4 - Virtual System is to be migrated using TLS with strict" + "verifcation of the remote certificates.\n" + "A value of 5 - Virtual System is to be migrated using TCP.\n" + "A value of 6 - Virtual System is to be migrated using UNIX sockets" + "(localhost only).\n"), + ValueMap {"0","1","2","3","4","5","6"}, + Values { "Unknown", "Other", "SSH", "TLS", "TLS Strict", "TCP", "UNIX" }] + uint16 TransportType; };
I guess it speaks well for the quality of the set that I have to resort to picking on string literals in a mof file, but IMHO the description is a bit on the verbose side. I'm all for people actually giving descriptions, but really it doesn't seem like the per-value description offers any information that's not already pretty explicit in ValueMap/Values pair. Thoughts, anybody? -- -Jay