Re: [Libvirt-cim] [PATCH] [TEST] Added disk backked pool support

Deepti B. Kalakeri wrote: > # HG changeset patch > # User Deepti B.Kalakeri <deeptik(a)linux.vnet.ibm.com&gt; > # Date 1248856464 25200 > # Node ID 72508ebffdece413437b820de84e0c69bc577405 > # Parent f7cbecb195e3800513372d4466393538809923e3 > [TEST] Added disk backked pool support > > Signed-off-by: Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com&gt; > > diff -r f7cbecb195e3 -r 72508ebffdec > suites/libvirt-cim/misc_cimtests/create_verify_storagepool.py Looks good, although you'll want to be sure you verify the parameters passed in for disk pools. verify_inputs() only verifies the inputs for fs, logical, and scsi pools. Oops! the checks for disk and fs pools are same I forgot to include pooltype = disk in the if loop .. I will do that and submit the patch..