Re: [Libvirt-cim] [PATCH 2/4] Fix possible memory leaks
On 01/18/2012 02:54 AM, Sharad Mishra wrote:
[snip]
> diff --git a/libxkutil/xmlgen.c b/libxkutil/xmlgen.c
> index 96b4e96..7fff4d1 100644
> --- a/libxkutil/xmlgen.c
> +++ b/libxkutil/xmlgen.c
> @@ -928,7 +928,6 @@ char *device_to_xml(struct virt_device *_dev)
> dominfo->dev_input = dev;
> break;
> default:
> - cleanup_virt_devices(&dev, 1);
This change is causing FilterList -> 03_create.py to dump core. There are
few others that are segfaulting.
-Sharad
You're right, it will end up in a double-free. Thanks for the spot. Will
send the patch with the correct fix once again.
Best regards, Etrunko
--
Eduardo de Barros Lima
Software Engineer, Open Virtualization
Linux Technology Center - IBM/Brazil
eblima(a)br.ibm.com