[TEST] #2 Adding set_interface_details() fn to the vxml.py.
This function give choice to add different network types to Xen/XenFV/KVM guest.
Changes:
From patch 1 to 2:
1) Removed the extra param used in the set_interface_details() fn. 2) Made the xxx_default_net_type defined in const.py for Xen/XenFV/KVM as network. 3) Removed the individual xxx_default_net_type for Xen/XenFV/KVM. 4) Defined common variable default_net_type in const.py the individual. 5) Changed the vxml.py to use the common variable default_net_type of const.py.
Signed-off-by: Deepti B. Kalakeri <deeptik@linux.vnet.ibm.com>
Excellent Deepti - this looks great. Just a few minor notes:
diff -r 959719c32cc9 -r 8252a996154a suites/libvirt-cim/lib/XenKvmLib/const.py
#vxml.LXCXML LXC_init_path = os.path.join(_image_dir, 'cimtest_lxc_init') LXC_default_tty = '/dev/ptmx' -LXC_default_mp = '/tmp' -LXC_default_source = '/tmp/lxc_files'
We don't want to remove the LXC pieces. This probably a result of the difference between your working copy and the updates Zhengang recently made. Othwerwise, this looks great. Thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com