Re: [Libvirt-cim] [PATCH] VirtualSystemManagementService: Always update domain device information

"Eduardo Lima \(Etrunko\)" <eblima(a)linux.vnet.ibm.com&gt; Sent by: libvirt-cim-bounces(a)redhat.com 09/20/2011 01:53 PM Please respond to List for discussion and development of libvirt CIM

To libvirt-cim(a)redhat.com cc Subject [Libvirt-cim] [PATCH] VirtualSystemManagementService: Always update domain device information src/Virt_VirtualSystemManagementService.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) # HG changeset patch # User Eduardo Lima (Etrunko) <eblima(a)br.ibm.com&gt; # Date 1316551891 10800 # Node ID 25c6de6ebf094bf602e95ddf01dd39a6c5c1804a # Parent 9a59a56e226f3f800ff7214b81ab5f2fe6362fcc VirtualSystemManagementService: Always update domain device information I noticed that a call to ModifyResourceSettings was causing devices description to be lost. It happens that there was an explicit check in the code that resulted in the device information to be updated only if the specified

was running. This patch removes that block and now the resulting domain xml after the ModifyResourceSettings call will keep the device information. Signed-off-by: Eduardo Lima (Etrunko) <eblima(a)br.ibm.com&gt; diff --git a/src/Virt_VirtualSystemManagementService.c b/src/ Virt_VirtualSystemManagementService.c --- a/src/Virt_VirtualSystemManagementService.c +++ b/src/Virt_VirtualSystemManagementService.c @@ -2349,15 +2349,6 @@ update_dominfo(dominfo, refcn); - if (!domain_online(dom)) { - CU_DEBUG("VS `%s' not online; skipping dynamic update", - dominfo->name); - cu_statusf(_BROKER, &s, - CMPI_RC_OK, - ""); - goto out; - } - CU_DEBUG("Doing dynamic device update for `%s'", dominfo->name); if (func(dom, dev) == 0) { _______________________________________________ Libvirt-cim mailing list Libvirt-cim(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim