On Fri, Nov 09, 2007 at 08:31:00AM -0800, Dan Smith wrote:
DV> I would add $(WEB_PAGES) to $(EXTRA_DIST)
Ah, right.
DV> and probably not remove on make clean to be able to 'make dist' DV> with them embedded in the tarball as xsltproc is not really a DV> build requirement.
Yep, good point.
DV> hum ... on uninstalls shouldn't ldconfig be run after the list DV> have been removed (and hence in %postun) ?
Ah, right.
DV> Except those tiny issues looks fine to me,
Replacement patch on the way... :)
Thanks for applying your experienced eye to this packaging stuff!
Heh, I don't understand much to the CIM C code so I try to compensate :) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/