Would it be better to have a list of all the resource types, and then call _get_devices() in a loop? This is probably fine as is, and I don't suspect we'll add more resource types in the future, so it's probably not worth worrying about.
Thoughts? Good idea. I will update svpc_types with an array for all resource types and use this one to loop over here. I will send this out as a separate
Kaitlin Rupert wrote: patch set.
Should inst_list_free(&list); go after the out:?
Even if list.cur == 0, we still probably want to set list->list = NULL to be sure.
I had a look into libcmpiutil and its possible to remove this check (list.cur==0) as cu_return_instance_names() and cu_return_instances() take care of this case. Thanks for making me aware of this. -- Regards Heidi Eckhart Software Engineer IBM Linux Technology Center - Open Hypervisor