Re: [Libvirt-cim] [PATCH 1 of 2] Enhance RegisteredProfile to support getInstance and gets static ID

HE> + instance = reg_prof_instance(_BROKER, NAMESPACE(ref), properties, profiles[i]); Minor nit, but it would be appreciated if you could break this (and other long lines) into less-than-80-columns by putting each parameter on its own line. We're pretty consistent with that style everywhere else. HE> diff -r 53903e7822dd -r bd925f5f9fda src/Virt_RegisteredProfile.h HE> --- a/src/Virt_RegisteredProfile.h Tue Oct 30 12:48:28 2007 +0100 HE> +++ b/src/Virt_RegisteredProfile.h Wed Oct 31 09:54:18 2007 +0100 HE> @@ -22,7 +22,8 @@ HE> #define __VIRT_REGISTERED_PROFILE_H HE> CMPIInstance *reg_prof_instance(const CMPIBroker *broker, HE> - const CMPIObjectPath *ref, HE> + const char *namespace, HE> + const char **properties, HE> struct reg_prof *profile); It looks like the original version had some hard tabs in it. Your "properties" parameter is right, but your "namespace" one still has hard tabs. Other than that, I'll defer this ack to Jay, since he's more familiar with the profile stuff than I. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com