Re: [Libvirt-cim] [PATCH] Change method arg type in VSMS AddResourceSettings
lizg(a)cn.ibm.com wrote:
# HG changeset patch
# User Zhengang Li <lizg(a)cn.ibm.com>
# Date 1197944392 -28800
# Node ID 58868e43ae199187436f1709da9177e4fa0a8f3d
# Parent 72b93a4339e1c13080d6a6d80a580a7742c0b851
Change method arg type in VSMS AddResourceSettings
Signed-off-by: Zhengang Li <lizg(a)cn.ibm.com>
diff -r 72b93a4339e1 -r 58868e43ae19 src/Virt_VirtualSystemManagementService.c
--- a/src/Virt_VirtualSystemManagementService.c Fri Dec 14 10:37:01 2007 +0100
+++ b/src/Virt_VirtualSystemManagementService.c Tue Dec 18 10:19:52 2007 +0800
@@ -1076,7 +1076,7 @@ static struct method_handler AddResource
static struct method_handler AddResourceSettings = {
.name = "AddResourceSettings",
.handler = add_resource_settings,
- .args = {{"AffectedConfiguration", CMPI_string},
+ .args = {{"AffectedConfiguration", CMPI_ref},
{"ResourceSettings", CMPI_stringA},
ARG_END
}
Good to have the DCO now, but in the future don't forget that this
should get a #2 since it was a resend. Hardly a grievous error on small
patch like this, but a good habit to get into. :)
--
-Jay