Re: [Libvirt-cim] [PATCH v4] Fix AppliedFilterList creation and deletion

On 01/26/2012 06:01 PM, Chip Vincent wrote: > From: Chip Vincent<cvincent(a)us.ibm.com> > > Fixes many small issues with the current AppliedFilterList provider. > > 1) Fix Create to properly return a complete object path and fix Delete to > properly parse that path. > > 2) Persist applied filer rules. Since it's not possible to dyanmically update > a single device, I've changed the code to modify and re-define the VM to > essentially add/remove ACL filter associations. > > I also updated the code to minimize domain/device parsing overhead. For > some strange reason, our internal APIs sometimes take a virDomainPtr and > other times a struct domain * forcing providers who work with domains > *and* devices to parse everything twice. Until the internal APIs are > cleaned up, I simply parse everything once and then fetch the device > manually from the struct domain *. > > 3) Add VIR_DOMAIN_XML_INACTIVE to virDomainGetXML(). By default, libvirt only > returns the XML of the running domain. We need to fetch the *stored* XML > that will be used for the next boot so that all changes made while the VM > is running are preserved. > > Changes from v3: > - Fix NestedFilterList DeleteInstance > - Fix remove_filter_ref() in acl_parsing.c (intend to refactor in > future patch) > +1. Yay, tests passed without crashing. :) I'll finish the cimtest patch and submit to the list.