Re: [Libvirt-cim] [PATCH] [TEST] Add cim_destroy to VirtCIM class
Kaitlin Rupert wrote:
> + def cim_destroy(self, ip):
> + service = vsms.get_vsms_class(self.virt)(ip)
> + cs_cn = get_typed_class(self.virt, 'ComputerSystem')
> + target = pywbem.cim_obj.CIMInstanceName(cs_cn, keybindings = {
> + 'Name':
> self.domain_name,
> +
> 'CreationClassName': cs_cn})
Sorry to be nitpicky - can you set the keybindings on a separate line?
As it is now, the arguments for CIMInstanceName() are wrapping an 80
character line.
Good catch! I sent another patch fixing format and some bug in this
file.
I'll rebase this one on top of that.
Otherwise, this looks good!
Thanks!
--
- Zhengang