Heidi Eckhart wrote:
Kaitlin Rupert wrote:
+static CMPIStatus return_vsmsd(const CMPIObjectPath *ref, + const CMPIResult *results, + bool name_only, + bool is_get_inst) +{ + CMPIInstance *inst = NULL; + CMPIStatus s; + + s = get_migration_sd(ref, &inst, _BROKER, is_get_inst);
This is seg faulting the provider for a request against Xen on a KVM only system (and reverse). The reason is that get_migration_sd() returns with OK but no instances for Xen. This inst==NULL seg faults the following returns.
Thanks Heidi - I thought I had tested for this, but I had tested incorrectly. I didn't have CMPIInstance *inst = NULL; in the previous patch, but I got compiler warnings this time around. I'll send a fix with a check for if ((s.rc == CMPI_RC_OK) && (inst != NULL)) since this is a case where we don't want to return an error if we cannot connect, but we also don't want to seg fault either. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com