Re: [Libvirt-cim] [PATCH 3 of 6] Add build support forVirtualSystemMigrationService
Hi Dan,
[...]
+
+// Placeholder definition until schema is available upstream
+
+class CIM_VirtualSystemMigrationService : CIM_Service {
+ uint32 VirtualSystemIsMigratableToHost(
That one is called 'CheckVirtualSystemIsMigratableToHost' upstream -
although I like your shorted name better as 'Check' is already implied
by the rest :-). Think I will comment as such to the author of that CR [1].
+ [Out]
+ CIM_ConcreteJob REF Job,
+ [In, EmbeddedInstance("CIM_ResourceAllocationSettingData")]
+ string NewResourceSettingData[],
+ [In, EmbeddedInstance("CIM_SettingData")]
+ string MigrationSettingData,
+ [In, EmbeddedInstance("CIM_VirtualSystemSettingData")]
+ string NewSystemSettingData,
+ [In]
+ CIM_ComputerSystem REF ComputerSystem,
+ [In]
+ string DestinationHost);
Method arguments have a different order in the CR.
+
+ uint32 MigrateVirtualSystemToHost(
+ [Out]
+ CIM_ConcreteJob REF Job,
+ [In, EmbeddedInstance("CIM_ResourceAllocationSettingData")]
+ string NewResourceSettingData[],
+ [In, EmbeddedInstance("CIM_SettingData")]
+ string MigrationSettingData,
+ [In, EmbeddedInstance("CIM_VirtualSystemSettingData")]
+ string NewSystemSettingData,
+ [In]
+ CIM_ComputerSystem REF ComputerSystem,
+ [In]
+ string DestinationHost);
+
+};
Same comment.
Cheers,
Jim
[1]
http://www.dmtf.org/apps/org/workgroup/cim-core/download.php/32768/CIMCor...