Re: [Libvirt-cim] [PATCH 2 of 3] This patch exposes error messages from libvirt calls in ComputerSystem
@@ -398,19 +398,27 @@
if (get_dominfo(dom, &domain) == 0) {
CU_DEBUG("Unable to get domain information");
- cu_statusf(_BROKER, &s,
- CMPI_RC_ERR_FAILED,
- "Unable to get domain information");
+ virt_set_status(broker, &s,
+ CMPI_RC_ERR_FAILED,
+ virDomainGetConnect(dom),
+ "Unable to get domain XML description");
Just a minor changer here.. We're doing 2 steps in the get_dominfo() call:
1) We're getting the XML from libvirt
2) We're parsing the XML and storing the domain info in a struct.
So I would change this from "Unable to get domain XML description" to
"Unable to get domain information" because the failure could be in
either step.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com