Deepti B. Kalakeri wrote:
# HG changeset patch # User Deepti B. Kalakeri <deeptik@linux.vnet.ibm.com> # Date 1208960938 -19800 # Node ID 25d9015078055a6f6f3a6975fd3c48c4c0efef24 # Parent 413ef6a636d51ab12f16588268c8debe4d952f05 [TEST]updating 01_forward.py to use of the lib fn conf_file(), cleanup_restore() and create_diskpool_file()
Signed-off-by: Deepti B. Kalakeri <deeptik@linux.vnet.ibm.com>
diff -r 413ef6a636d5 -r 25d901507805 suites/libvirt-cim/cimtest/SettingsDefineCapabilities/01_forward.py
Can you split this into two patches? The commit log says that it's modifying the diskpool conf files, but the patch also converts this to a KVM test. This fails for me on KVM with updated sources and libvirt-0.4.2. In order for it to work with such environment, we'll need to have storage pool support in place.
-def print_error(index, fieldname, assoc_info, exp_value): - ret_value = assoc_info[index][fieldname] - Globals.logger.error("%s Mismatch", fieldname) - Globals.logger.error("Returned %s instead of %s", ret_value, exp_value) +def print_error(fieldname, ret_value, exp_value): + logger.error("%s Mismatch", fieldname) + logger.error("Returned %s instead of %s", ret_value, exp_value)
You can use the library function instead. There's also some strange indenting in this patch. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com