DV> Assuming I understand the example, there is also no namespace in DV> those element, checking node->ns == NULL might be a good idea (or DV> not if namespaced) Excuse my ignorance here, but why is this important? DV> when i have realloc in loop I usually do things like size *= 2 to DV> escape a linear growing model. Fair enough. DV> Add & -> & and ' -> ''' would be good for completeness Ah, yes, I actually meant to put something in my patch message asking what other escapes I should add. DV> I would add (XML_PARSE_NOENT | XML_PARSE_NOCDATA | DV> XML_PARSE_NONET) to ask the parser to replace entities references, DV> change CDATA section into normal text and forbid network access DV> (should not occur, but better safe than sorry :-) Okay. DV> Looks fine, maybe a small check that no memory allocation is lost is in DV> order though, it's easy to forget something. Yeah, I need to go back through with a fine-toothed comb. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com