Dan Smith wrote:
disk_file = '/tmp/diskpool.conf'
KR> This test should use the diskpool support in the provider.
Additionally, we should make the standard location for the diskpool.conf file more appropriate. That way, the test suite will work against the development tree in addition to a released version, which would want to put it somewhere other than /tmp, of course.
Since we don't have any other configuration files right now, I'm not sure where the best place for this is. Perhaps /etc/libvirt/?
I think using a libvirt dir is less obvious than using a libvirt-cim named one. However, I think it's silly to have a directory with just one file. Do you anticipate the need for other config files? I'm not sure if we'll need a way to persist data in the future (we haven't had such a need so far..). Although using diskpool.conf to configure the diskpool is not obvious in itself. I suspect that's something will need to well documented. At which point, the naming convention becomes less important. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com