Heidi Eckhart wrote:
# HG changeset patch # User Heidi Eckhart <heidieck@linux.vnet.ibm.com> # Date 1195812344 -3600 # Node ID a479cec9721a58c537929206bc5190b22f709fc1 # Parent 4cce597d4e48b5e3efc6e4307be3234bd3051c9b Enumeration of RegisteredProfile class is returning wrong instances Signed-off-by: Heidi Eckhart <heidieck@linux.vnet.ibm.com>
The move to connect_by_classname() work looks good, and in general I like the cleanup of reg_prof_instance(), but I have one question about it. You added a virConnectPtr to the argument list, and I'll grant the function does need a connection it doesn't already have in there, by why not pass in a CMPIObjectPath so that it used to make the connection? That way all the callers don't have to bother creating their own connections just to pass them in, and since reg_prof_instance is already being given a CMPIBroker and creates its own CMPIStatus, giving it the ref will give it everything it needs to make the appropriate connection and do the same "if (conn == NULL) goto out;" that the calling functions do right now. -- -Jay