Re: [Libvirt-cim] [PATCH] Avoid clobbering disk flags on redefine
Dan Smith wrote:
[...]
-static char *disk_file_xml(const char *path, const char *vdev)
+static char *disk_file_xml(struct disk_device *dev)
{
char *xml;
int ret;
@@ -140,16 +144,20 @@
"<disk type='file'
device='disk'>\n"
" <source file='%s'/>\n"
" <target dev='%s'/>\n"
+ "%s"
+ "%s"
"</disk>\n",
- path,
- vdev);
+ dev->source,
+ dev->virtual_dev,
+ dev->readonly ? "<readonly/>" : "",
+ dev->shareable ? "shareable/>" : "");
Pulled the trigger a little early on my previous ack. That last line
needs to be
+ dev->shareable ? "<shareable/>" :
"");
Jim