Deepti B Kalakeri wrote:
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1210779243 -28800 # Node ID dcb1f04780e641973d1070440bc6f50fac2e9831 # Parent cdcf642c493a548d2deb499f223bb9a1f414cb3c [TEST] Add PoolXML class for creating a virtual pool in vxml.py
Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com>
Please sign with your DCO, not mine.
+ + pool = self.add_sub_node(self.xdoc, 'pool', type='dir') + self.add_sub_node(pool, 'name', self.pool_name) + source = self.add_sub_node(pool, 'source') + self.add_sub_node(source, 'device', path='/tmp')
Also , creation of the pool works fine without the source tags.
I source is needed for some kind of pools, such as iscsi pools. However, for dir type storage pools, agreed: you don't need the source tag. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com