libvirt-cim-bounces@redhat.com wrote on 2008-11-04 06:13:53:
+def run_remote_guest(ip, domain, command): + """ Execute commands on remote guest console. + """ + + cmd = 'python %s %s "%s"' % (CONSOLE_APP_PATH, domain, command) + + return run_remote(ip, cmd) + +
Kaitlin,
I think we can remove run_remote_guest to xm_virt_util.py under ../libvirt-cim/lib/XenKvmLib, because it have to be used by live.py under lib/VirtLib. We have to make it stay in utils.py.
I'm sorry, I intend to say we cann't remove run_remote_guest() from ../lib/XenKvmLib to xm_virt_util.py =)
Thoughts?
If you agree to make it stay in utils.py, I will rework on this patch. Thanks!
I'm sorry Daisy - I'm not sure I understand what you mean here. Are you
saying that run_remote_guest() needs to stay in lib/VirtLib/utils.py?
If so, why?
Kaitlin, I make run_remote_guest() stay in lib/VirtLib/utils in my patch today. Also I update all related helper functions. If this function has to be moved to libvirt-cim/lib/XenKvmLib, I will cook up it on follow up patch. Thanks!
-- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim