Re: [Libvirt-cim] [PATCHv2 6/7] VSMS: Support for domains with console devices

It's possible that tmp_ip == NULL, so how about this instead: if (tmp_ip == NULL) { ret = 0; goto out; } strcat(tmp_ip, "]"); You won't be getting too far if realloc() fails anyway, but better than core in a few lines on strdup(tmp_ip); failure.

> + } > } else { > ret = sscanf(id, "%a[^:]:%as", &tmp_ip, &tmp_port); > } > > - if (ret != 2) { > + /* ret == 2: address and port, ret == 1: address only */ > + if (ret < 1) { > ret = 0; > goto out; > } > > - if (ip) > + if (ip) { > *ip = strdup(tmp_ip); If 'tmp_ip == NULL' then this is problematic Everything else seems fine - so if you want me to sqaush in the above I will do so and then just push.