Re: [Libvirt-cim] [PATCH 1 of 2] Schema and Makefile changes for the RedirectionService

KR> +[Provider("cmpi::Virt_RedirectionService")] KR> +class Xen_RedirectionService : CIM_RedirectionService KR> +{ KR> +}; KR> + KR> +[Provider("cmpi::Virt_RedirectionService")] KR> +class KVM_RedirectionService : CIM_RedirectionService KR> +{ KR> +}; KR> + KR> +[Provider("cmpi::Virt_RedirectionService")] KR> +class LXC_RedirectionService : CIM_RedirectionService KR> +{ KR> +}; Should this be Xen_ConsoleRedirectionService? I don't know much about the KVM model so maybe this is silly, but it seems like maybe any other redirection service we implemented would be sufficiently distinct from this that it wouldn't make much sense to have them in the same provider. If you think that this isn't a concern, then I'll take your word for it :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com