Re: [Libvirt-cim] [PATCH] Fix crash when creating ACL filter lists

On 07/21/2011 02:45 PM, Chip Vincent wrote: > > > On 07/21/2011 01:35 PM, Eduardo Lima (Etrunko) wrote: > >> >> Looks good. With this patch I was able to successfully create a new >> filter with a filterref entry referring to another pre-existent filter. >> I was not able to create the AppliedFilterList instance though, i.e, >> associate a filter to a network interface of a given domain. Is there >> any restriction about that? If so, the patch is good to go and a proper >> fix where necessary can be provided by another patch. >> > > Yep. I mentioned this in the comment: > > "It appears libvirt w/ qemu does not support dynamic updating of virtual > net devices in 0.8.1 so CreateInstance() will still fail (but not crash) > in that version. Looking for alternatives to provide dynamic support and > will post in a follow-on patch. " > > You should be seeing an error message like "failed to dynamically update > device". I'm working on a separate patch for that now along with write > support for filter rules. > Uh, my bad, sorry. Go for it, then. :) >> Best regards, >> >