Re: [Libvirt-cim] [PATCH 0/3] Console Fixes and Enhancements
On 10/02/2013 05:16 AM, Viktor Mihajlovski wrote:
On 09/20/2013 05:25 PM, Viktor Mihajlovski wrote:
> Enabling cimtest for the Console RASDs required a few
> improvements. The XML generation code was simplified,
> a logical device class for consoles had to be added and
> a bug in the KVM redirection service was fixed.
>
> Viktor Mihajlovski (3):
> libxkutil: Simplify XML handling of consoles
> Virt_Device: Add a device class for consoles
> KVMRedirectionSAP: Only return redirection SAPs for VNC graphics
>
> libxkutil/device_parsing.c | 12 +-----
> libxkutil/xmlgen.c | 76
> ---------------------------------
> schema/DisplayController.mof | 15 +++++++
> schema/DisplayController.registration | 3 ++
> src/Virt_Device.c | 18 ++++----
> src/Virt_ElementSettingData.c | 3 ++
> src/Virt_KVMRedirectionSAP.c | 23 ++++++----
> src/Virt_SettingsDefineState.c | 6 +++
> src/Virt_SystemDevice.c | 3 ++
> src/Virt_VSSDComponent.c | 3 ++
> 10 files changed, 59 insertions(+), 103 deletions(-)
>
Ping?
Sorry - been heads down in another area... Always meant to get to this..
Anyway, about the only concern I have is the applicability of the changes
in patch 2/3 to 'Virt_Device.c' in 'res_type_from_device_classname' at
least
with respect it be related to the console changes. It seems to be a separate
issue unrelated to ConsoleDisplayController and should be its own patch.
I also suppose in patch 3/3 the 'check_graphics' could change from a bool
to an int returning "pos" as -1 or >= 0 for it's location in list. But
that's just a minor thing.
John