Re: [Libvirt-cim] [PATCH 1 of 2] Add property filtering to RASD provider

KR> + const char *keys[] = {"InstanceID", NULL}; KR> + s = CMSetPropertyFilter(inst, properties, keys); KR> + /* FIXME - in case of an error, should we continue on? */ I think we should do exactly what you have: log a message and continue on. I doubt much more will work if this part fails (due to memory or something), so the error will be caught later. If it's unrelated and the rest can proceed, I think that's better than dying here, since the property filter is really just an optimization. Since we don't do it anywhere else, a failure here will just make RASD behave like everything else :) +1 from me. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com